You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "543202718 (via GitHub)" <gi...@apache.org> on 2023/04/14 01:12:22 UTC

[GitHub] [iotdb] 543202718 opened a new pull request, #9610: [Optimization] Reduce the size of UDF-Library jar

543202718 opened a new pull request, #9610:
URL: https://github.com/apache/iotdb/pull/9610

   The size of UDF-Library jar is about **94MB**, which is extremely and surprisingly large. Since too many useless dependencies are included in the jar package, it is inconvenient for users to use such a large package. With the following optimizations, the size is reduced to only **19MB**.
   
   + Remove unused dependencies, e.g., **iotdb-session**, **jama**, **java-local-outlier-factor**, **gson**, **iotdb-server**.
   + Replace the remaining *org.apache.iotdb.tsfile.file.metadata.enums.TSDataType* to *org.apache.iotdb.udf.api.type.Type*. Meanwhile, *org.apache.iotdb.commons.udf.utils.UDFDataTypeTransformer* is also removed. Thus, dependency **tsfile** is removed and **node-commons** is changed to much smaller **udf-api**.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] HTHou commented on a diff in pull request #9610: [ISSUE-9611] Reduce the size of UDF-Library jar

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on code in PR #9610:
URL: https://github.com/apache/iotdb/pull/9610#discussion_r1166250256


##########
library-udf/Readme.md:
##########
@@ -0,0 +1,7 @@
+# README

Review Comment:
   ```suggestion
   <!--
   
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
       
           http://www.apache.org/licenses/LICENSE-2.0
       
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   
   -->
   # README
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [iotdb] HTHou merged pull request #9610: [ISSUE-9611] Reduce the size of UDF-Library jar

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #9610:
URL: https://github.com/apache/iotdb/pull/9610


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org