You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jl...@apache.org on 2026/06/23 19:25:15 UTC

(superset) branch claude/subdirectory-helpers-tdd updated: fix(reports): use post-route_base dashboard route in AlertReportModal

This is an automated email from the ASF dual-hosted git repository.

sadpandajoe pushed a commit to branch claude/subdirectory-helpers-tdd
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/claude/subdirectory-helpers-tdd by this push:
     new f7b04df6a16 fix(reports): use post-route_base dashboard route in AlertReportModal
f7b04df6a16 is described below

commit f7b04df6a16955bd9768d49e0593aa50c3213378
Author: Joe Li <jo...@preset.io>
AuthorDate: Tue Jun 23 12:25:01 2026 -0700

    fix(reports): use post-route_base dashboard route in AlertReportModal
    
    PR #40525 added `navigateTo(`/superset/dashboard/${dashboardId}`)` to the
    report-content link, which double-prefixes (`/<approot>/superset/...`) and
    404s under subdirectory deployments once `Superset.route_base` is empty.
    Migrate it to the post-route_base shape `/dashboard/${dashboardId}/` and let
    `navigateTo` → `ensureAppRoot` apply the deployment root, matching every
    other migrated dashboard navigation in this branch. Caught by the
    navigationUtils hard-coded-/superset/-literal invariant test.
    
    Co-Authored-By: Claude Opus 4.8 (1M context) <no...@anthropic.com>
---
 superset-frontend/src/features/alerts/AlertReportModal.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset-frontend/src/features/alerts/AlertReportModal.tsx b/superset-frontend/src/features/alerts/AlertReportModal.tsx
index df18f3a0e8e..67cf34e1b98 100644
--- a/superset-frontend/src/features/alerts/AlertReportModal.tsx
+++ b/superset-frontend/src/features/alerts/AlertReportModal.tsx
@@ -1427,7 +1427,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
 
   const openDashboardInNewTab = (dashboardId?: number | string | null) => {
     if (!dashboardId) return;
-    navigateTo(`/superset/dashboard/${dashboardId}`, { newWindow: true });
+    navigateTo(`/dashboard/${dashboardId}/`, { newWindow: true });
   };
 
   const onChartChange = (chart: SelectValue) => {