You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Walter Vaughan (JIRA)" <ji...@apache.org> on 2007/01/15 20:10:27 UTC
[jira] Created: (OFBIZ-628) Change ProductCategory dropdowns to
lookup windows
Change ProductCategory dropdowns to lookup windows
--------------------------------------------------
Key: OFBIZ-628
URL: https://issues.apache.org/jira/browse/OFBIZ-628
Project: Apache OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: product
Affects Versions: SVN trunk
Environment: All
Reporter: Walter Vaughan
Fix For: SVN trunk
There are several places in ofBiz where a drop down window is used to select a ProductCategory. However, in installations with a significant number of categories, the overhead of a sequential scan query causes severe slowdowns in the performance of ofBiz, and overloads the browser client.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Assigned: (OFBIZ-628) Change ProductCategory dropdowns
to lookup windows
Posted by Si Chen <si...@opensourcestrategies.com>.
Guido Amarilla wrote:
> Si,
> In EditProduct screen the Primary Category lookup window allows the
> selection of any category, not only the Product's categories. I think
> that in this case is more useful to have a dropdown.
> I tested this with 494515 and I can select a Primary Categorý and it
> is not updated in EditProductCategories screen.
>
> Guido Amarilla
>
> 2007/1/16, Si Chen (JIRA) <ji...@apache.org>:
>>
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Si Chen reassigned OFBIZ-628:
>> -----------------------------
>>
>> Assignee: Si Chen
>>
>> > Change ProductCategory dropdowns to lookup windows
>> > --------------------------------------------------
>> >
>> > Key: OFBIZ-628
>> > URL: https://issues.apache.org/jira/browse/OFBIZ-628
>> > Project: Apache OFBiz (The Open for Business Project)
>> > Issue Type: Improvement
>> > Components: product
>> > Affects Versions: SVN trunk
>> > Environment: All
>> > Reporter: Walter Vaughan
>> > Assigned To: Si Chen
>> > Fix For: SVN trunk
>> >
>> > Attachments: patch_category_lookup
>> >
>> >
>> > There are several places in ofBiz where a drop down window is used
>> to select a ProductCategory. However, in installations with a
>> significant number of categories, the overhead of a sequential scan
>> query causes severe slowdowns in the performance of ofBiz, and
>> overloads the browser client.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of the
>> administrators:
>> https://issues.apache.org/jira/secure/Administrators.jspa
>> -
>> For more information on JIRA, see:
>> http://www.atlassian.com/software/jira
>>
>>
>>
>
>
Actually this is not necessarily always the case, and I'm not sure that
we should have this feature.
Also, please comment on the JIRA issue itself the future--it'll help
keep the discussion all in one place, which is nicer.
Si
Re: [jira] Assigned: (OFBIZ-628) Change ProductCategory dropdowns to lookup windows
Posted by Guido Amarilla <ga...@gmail.com>.
Si,
In EditProduct screen the Primary Category lookup window allows the
selection of any category, not only the Product's categories. I think
that in this case is more useful to have a dropdown.
I tested this with 494515 and I can select a Primary Categorý and it
is not updated in EditProductCategories screen.
Guido Amarilla
2007/1/16, Si Chen (JIRA) <ji...@apache.org>:
>
> [ https://issues.apache.org/jira/browse/OFBIZ-628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Si Chen reassigned OFBIZ-628:
> -----------------------------
>
> Assignee: Si Chen
>
> > Change ProductCategory dropdowns to lookup windows
> > --------------------------------------------------
> >
> > Key: OFBIZ-628
> > URL: https://issues.apache.org/jira/browse/OFBIZ-628
> > Project: Apache OFBiz (The Open for Business Project)
> > Issue Type: Improvement
> > Components: product
> > Affects Versions: SVN trunk
> > Environment: All
> > Reporter: Walter Vaughan
> > Assigned To: Si Chen
> > Fix For: SVN trunk
> >
> > Attachments: patch_category_lookup
> >
> >
> > There are several places in ofBiz where a drop down window is used to select a ProductCategory. However, in installations with a significant number of categories, the overhead of a sequential scan query causes severe slowdowns in the performance of ofBiz, and overloads the browser client.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
--
Guido Amarilla
[jira] Updated: (OFBIZ-628) Change ProductCategory dropdowns to
lookup windows
Posted by "Walter Vaughan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Walter Vaughan updated OFBIZ-628:
---------------------------------
Attachment: patch_category_lookup2
> Change ProductCategory dropdowns to lookup windows
> --------------------------------------------------
>
> Key: OFBIZ-628
> URL: https://issues.apache.org/jira/browse/OFBIZ-628
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Si Chen
> Fix For: SVN trunk
>
> Attachments: patch_category_lookup, patch_category_lookup2
>
>
> There are several places in ofBiz where a drop down window is used to select a ProductCategory. However, in installations with a significant number of categories, the overhead of a sequential scan query causes severe slowdowns in the performance of ofBiz, and overloads the browser client.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-628) Change ProductCategory dropdowns to
lookup windows
Posted by "Guido Amarilla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465343 ]
Guido Amarilla commented on OFBIZ-628:
--------------------------------------
I can´t find the issue associated to 494515, so I comment this here:
(excuse me if I am not clear, because I have a very limited english vocabulary and knowledge of the entities)
In EditProduct screen, when selecting a product´s Primary Category I am allowed to select a category to which this product is not a member. If I´m not wrong (and possibly I am) you shouldn´t be allowed to choose a primary category if the product is not member of that category. It looks like a check is missing here.
I think that the correct behaviour would be to add the product as a member of the selected primary category if it is not currently a member.
This patch was meant for installations with a great number of categories, but I wonder how many categories can a single product be member of simultaneously? If this number is small in every installation I don´t see a problem in keeping the dropdown for the Primary Category selection. In this case it would be faster with a drop down and won't create any overhead in the client.
> Change ProductCategory dropdowns to lookup windows
> --------------------------------------------------
>
> Key: OFBIZ-628
> URL: https://issues.apache.org/jira/browse/OFBIZ-628
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Si Chen
> Fix For: SVN trunk
>
> Attachments: patch_category_lookup, patch_category_lookup2
>
>
> There are several places in ofBiz where a drop down window is used to select a ProductCategory. However, in installations with a significant number of categories, the overhead of a sequential scan query causes severe slowdowns in the performance of ofBiz, and overloads the browser client.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-628) Change ProductCategory dropdowns to
lookup windows
Posted by "Leon Torres (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465268 ]
Leon Torres commented on OFBIZ-628:
-----------------------------------
Hi, a few comments about this patch. First, it has Debug logging and commented out code that should be removed.
Second, the patch is doing more than what the description says the issue is. Why was the if condition on productCategory removed in CategoryTabBar.ftl? Why remove the entity-one lookup for productCategory in the screen xml file?
> Change ProductCategory dropdowns to lookup windows
> --------------------------------------------------
>
> Key: OFBIZ-628
> URL: https://issues.apache.org/jira/browse/OFBIZ-628
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Si Chen
> Fix For: SVN trunk
>
> Attachments: patch_category_lookup
>
>
> There are several places in ofBiz where a drop down window is used to select a ProductCategory. However, in installations with a significant number of categories, the overhead of a sequential scan query causes severe slowdowns in the performance of ofBiz, and overloads the browser client.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-628) Change ProductCategory dropdowns to
lookup windows
Posted by "Walter Vaughan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464937 ]
Walter Vaughan commented on OFBIZ-628:
--------------------------------------
This should fix all the problems in the catalog area, facility, and order entry.
> Change ProductCategory dropdowns to lookup windows
> --------------------------------------------------
>
> Key: OFBIZ-628
> URL: https://issues.apache.org/jira/browse/OFBIZ-628
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Fix For: SVN trunk
>
> Attachments: patch_category_lookup
>
>
> There are several places in ofBiz where a drop down window is used to select a ProductCategory. However, in installations with a significant number of categories, the overhead of a sequential scan query causes severe slowdowns in the performance of ofBiz, and overloads the browser client.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-628) Change ProductCategory dropdowns to
lookup windows
Posted by "Leon Torres (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465310 ]
Leon Torres commented on OFBIZ-628:
-----------------------------------
Ok thanks for the update and clarification. Hopefully we'll get it in by today. :-)
> Change ProductCategory dropdowns to lookup windows
> --------------------------------------------------
>
> Key: OFBIZ-628
> URL: https://issues.apache.org/jira/browse/OFBIZ-628
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Si Chen
> Fix For: SVN trunk
>
> Attachments: patch_category_lookup, patch_category_lookup2
>
>
> There are several places in ofBiz where a drop down window is used to select a ProductCategory. However, in installations with a significant number of categories, the overhead of a sequential scan query causes severe slowdowns in the performance of ofBiz, and overloads the browser client.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-628) Change ProductCategory dropdowns to
lookup windows
Posted by "Walter Vaughan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465297 ]
Walter Vaughan commented on OFBIZ-628:
--------------------------------------
Removed the debug logging and code that we just commented out in the bean shell.
We removed the if statement because it was written such that it did a sequential scan of the entire ProductCatagory file to see if the ProductCategoryId existed. It the used the if statements to determine if it should display items to work with that product category. However, if it failed the "if" it didn't display an error message, it just left a 90% blank page with no reason, so it really wasn't error checking either. Now at least you get a nice short error message from ofBiz that you are working with an invalid ProductCategoryId.
> Change ProductCategory dropdowns to lookup windows
> --------------------------------------------------
>
> Key: OFBIZ-628
> URL: https://issues.apache.org/jira/browse/OFBIZ-628
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Si Chen
> Fix For: SVN trunk
>
> Attachments: patch_category_lookup, patch_category_lookup2
>
>
> There are several places in ofBiz where a drop down window is used to select a ProductCategory. However, in installations with a significant number of categories, the overhead of a sequential scan query causes severe slowdowns in the performance of ofBiz, and overloads the browser client.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-628) Change ProductCategory dropdowns to
lookup windows
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Si Chen closed OFBIZ-628.
-------------------------
Resolution: Fixed
Done in r 497094, 497101.
> Change ProductCategory dropdowns to lookup windows
> --------------------------------------------------
>
> Key: OFBIZ-628
> URL: https://issues.apache.org/jira/browse/OFBIZ-628
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Si Chen
> Fix For: SVN trunk
>
> Attachments: patch_category_lookup, patch_category_lookup2
>
>
> There are several places in ofBiz where a drop down window is used to select a ProductCategory. However, in installations with a significant number of categories, the overhead of a sequential scan query causes severe slowdowns in the performance of ofBiz, and overloads the browser client.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-628) Change ProductCategory dropdowns to
lookup windows
Posted by "eric schwartz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465304 ]
eric schwartz commented on OFBIZ-628:
-------------------------------------
the above info is not correct. we removed the if statement because the way the code worked was that it would do a lookup of all items in product category and if the lookup returned results it would show the content in the ftl file. when we removed the lookup (which was what was slowing down the page) the content was no longer displayed. i am not sure why this if statement was even neccessary. you wouldnt be able to navigate to this page unless you had product categories and even if you do get to the page and no product categories exist it would not let you do anything. for example if you pass it a bogus category it will tell you it cannot do the desired operation because the category does not exist. this if statement should have probably been removed regardless of our removing the lookup or not.
> Change ProductCategory dropdowns to lookup windows
> --------------------------------------------------
>
> Key: OFBIZ-628
> URL: https://issues.apache.org/jira/browse/OFBIZ-628
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Si Chen
> Fix For: SVN trunk
>
> Attachments: patch_category_lookup, patch_category_lookup2
>
>
> There are several places in ofBiz where a drop down window is used to select a ProductCategory. However, in installations with a significant number of categories, the overhead of a sequential scan query causes severe slowdowns in the performance of ofBiz, and overloads the browser client.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-628) Change ProductCategory dropdowns to
lookup windows
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465446 ]
Si Chen commented on OFBIZ-628:
-------------------------------
Yes I agree with you. This was functionality from before which should be restored. If there are no other objections, we'll put it back in.
> Change ProductCategory dropdowns to lookup windows
> --------------------------------------------------
>
> Key: OFBIZ-628
> URL: https://issues.apache.org/jira/browse/OFBIZ-628
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Si Chen
> Fix For: SVN trunk
>
> Attachments: patch_category_lookup, patch_category_lookup2
>
>
> There are several places in ofBiz where a drop down window is used to select a ProductCategory. However, in installations with a significant number of categories, the overhead of a sequential scan query causes severe slowdowns in the performance of ofBiz, and overloads the browser client.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (OFBIZ-628) Change ProductCategory dropdowns to
lookup windows
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Si Chen reassigned OFBIZ-628:
-----------------------------
Assignee: Si Chen
> Change ProductCategory dropdowns to lookup windows
> --------------------------------------------------
>
> Key: OFBIZ-628
> URL: https://issues.apache.org/jira/browse/OFBIZ-628
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Assigned To: Si Chen
> Fix For: SVN trunk
>
> Attachments: patch_category_lookup
>
>
> There are several places in ofBiz where a drop down window is used to select a ProductCategory. However, in installations with a significant number of categories, the overhead of a sequential scan query causes severe slowdowns in the performance of ofBiz, and overloads the browser client.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-628) Change ProductCategory dropdowns to
lookup windows
Posted by "Walter Vaughan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Walter Vaughan updated OFBIZ-628:
---------------------------------
Attachment: patch_category_lookup
> Change ProductCategory dropdowns to lookup windows
> --------------------------------------------------
>
> Key: OFBIZ-628
> URL: https://issues.apache.org/jira/browse/OFBIZ-628
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Walter Vaughan
> Fix For: SVN trunk
>
> Attachments: patch_category_lookup
>
>
> There are several places in ofBiz where a drop down window is used to select a ProductCategory. However, in installations with a significant number of categories, the overhead of a sequential scan query causes severe slowdowns in the performance of ofBiz, and overloads the browser client.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira