You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2014/08/14 21:57:59 UTC

Review Request 24710: SAMZA-371

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24710/
-----------------------------------------------------------

Review request for samza.


Bugs: SAMZA-371
    https://issues.apache.org/jira/browse/SAMZA-371


Repository: samza


Description
-------

rename systemstreampartition config to just be partition


Diffs
-----

  docs/learn/documentation/0.7.0/container/samza-container.md ab4f0e4aa52bf7b986c48d622389c80ed83a4c7d 
  samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 3b6685e00837a4aaf809813e62b7e52823bc07a9 

Diff: https://reviews.apache.org/r/24710/diff/


Testing
-------


Thanks,

Chris Riccomini


Re: Review Request 24710: SAMZA-371

Posted by Naveen Somasundaram <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24710/#review50650
-----------------------------------------------------------

Ship it!


Ship It!

- Naveen Somasundaram


On Aug. 14, 2014, 9:18 p.m., Chris Riccomini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24710/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 9:18 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-371
>     https://issues.apache.org/jira/browse/SAMZA-371
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> add docs for job.partition.grouper.factory
> 
> 
> rename systemstreampartition config to just be partition
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/0.7.0/container/samza-container.md ab4f0e4aa52bf7b986c48d622389c80ed83a4c7d 
>   docs/learn/documentation/0.7.0/jobs/configuration-table.html ea6b1ef9b38f7c940c8b98791358ab16837a271d 
>   samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 3b6685e00837a4aaf809813e62b7e52823bc07a9 
> 
> Diff: https://reviews.apache.org/r/24710/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Riccomini
> 
>


Re: Review Request 24710: SAMZA-371

Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24710/
-----------------------------------------------------------

(Updated Aug. 14, 2014, 9:18 p.m.)


Review request for samza.


Bugs: SAMZA-371
    https://issues.apache.org/jira/browse/SAMZA-371


Repository: samza


Description (updated)
-------

add docs for job.partition.grouper.factory


rename systemstreampartition config to just be partition


Diffs (updated)
-----

  docs/learn/documentation/0.7.0/container/samza-container.md ab4f0e4aa52bf7b986c48d622389c80ed83a4c7d 
  docs/learn/documentation/0.7.0/jobs/configuration-table.html ea6b1ef9b38f7c940c8b98791358ab16837a271d 
  samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 3b6685e00837a4aaf809813e62b7e52823bc07a9 

Diff: https://reviews.apache.org/r/24710/diff/


Testing
-------


Thanks,

Chris Riccomini


Re: Review Request 24710: SAMZA-371

Posted by Chinmay Soman <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24710/#review50625
-----------------------------------------------------------

Ship it!


Ship It!

- Chinmay Soman


On Aug. 14, 2014, 7:57 p.m., Chris Riccomini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24710/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 7:57 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-371
>     https://issues.apache.org/jira/browse/SAMZA-371
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> rename systemstreampartition config to just be partition
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/0.7.0/container/samza-container.md ab4f0e4aa52bf7b986c48d622389c80ed83a4c7d 
>   samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 3b6685e00837a4aaf809813e62b7e52823bc07a9 
> 
> Diff: https://reviews.apache.org/r/24710/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Riccomini
> 
>