[GitHub] [rocketmq] sunxin1993 opened a new issue #1248: unnecessary code in LatencyFaultToleranceImpl at latest version

[GitBox <gi...@apache.org>]

sunxin1993 opened a new issue #1248: unnecessary code in LatencyFaultToleranceImpl at latest version
URL: https://github.com/apache/rocketmq/issues/1248
 
 
   `  @Override
       public String pickOneAtLeast() {
           final Enumeration<FaultItem> elements = this.faultItemTable.elements();
           List<FaultItem> tmpList = new LinkedList<FaultItem>();
           while (elements.hasMoreElements()) {
               final FaultItem faultItem = elements.nextElement();
               tmpList.add(faultItem);
           }
   
           if (!tmpList.isEmpty()) {
   
               Collections.shuffle(tmpList);
   
   
               Collections.sort(tmpList);
   
               final int half = tmpList.size() / 2;
               if (half <= 0) {
                   return tmpList.get(0).getName();
               } else {
                   final int i = this.whichItemWorst.getAndIncrement() % half;
                   return tmpList.get(i).getName();
               }
           }
   
           return null;
       }`
   
   i think there is no need to use Collections.shuffle(tmpList) before  Collections.sort(tmpList). i think you can delete it.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services