You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/11 18:29:59 UTC
[GitHub] [incubator-superset] robdiciuccio opened a new pull request #9119:
Update PyArrow to 0.16.0
robdiciuccio opened a new pull request #9119: Update PyArrow to 0.16.0
URL: https://github.com/apache/incubator-superset/pull/9119
### CATEGORY
Choose one
- [x] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Update PyArrow from 0.15.1 to 0.16.0. Includes a number of fixes and enhancements, including improvements to Pandas conversion with nested data types.
Complete CHANGELOG:
https://github.com/apache/arrow/blob/master/CHANGELOG.md
Includes a fix for https://github.com/apache/incubator-superset/issues/8843
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
- CI tests pass
- Queries run in SQL Lab succeed
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #8843
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@john-bodley @serenajiang @dpgaspar @nytai @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on issue #9119: Update
PyArrow to 0.16.0
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on issue #9119: Update PyArrow to 0.16.0
URL: https://github.com/apache/incubator-superset/pull/9119#issuecomment-585313350
@john-bodley this does not appear to handle the issue with lists containing mixed int and string values. We'll have to handle that explicitly with additional serialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on issue #9119: Update
PyArrow to 0.16.0
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on issue #9119: Update PyArrow to 0.16.0
URL: https://github.com/apache/incubator-superset/pull/9119#issuecomment-585491641
Seeing a potential issue with this new version raising `OSError: Invalid flatbuffers message.`. Investigating.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #9119: Update
PyArrow to 0.16.0
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #9119: Update PyArrow to 0.16.0
URL: https://github.com/apache/incubator-superset/pull/9119
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9119:
Update PyArrow to 0.16.0
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9119: Update PyArrow to 0.16.0
URL: https://github.com/apache/incubator-superset/pull/9119#issuecomment-584787868
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9119?src=pr&el=h1) Report
> Merging [#9119](https://codecov.io/gh/apache/incubator-superset/pull/9119?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4f73f8a1f9fec7f15ec760d6d98617bbe04f4023?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9119?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9119 +/- ##
=======================================
Coverage 58.91% 58.91%
=======================================
Files 372 372
Lines 11996 11996
Branches 2937 2937
=======================================
Hits 7068 7068
Misses 4750 4750
Partials 178 178
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9119?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9119?src=pr&el=footer). Last update [4f73f8a...7e4527f](https://codecov.io/gh/apache/incubator-superset/pull/9119?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on issue #9119: Update
PyArrow to 0.16.0
Posted by GitBox <gi...@apache.org>.
john-bodley commented on issue #9119: Update PyArrow to 0.16.0
URL: https://github.com/apache/incubator-superset/pull/9119#issuecomment-584784905
@robdiciuccio do you know if the bug fixes will resolve the issue @serenajiang reported in https://github.com/apache/incubator-superset/pull/9096#issuecomment-584449351.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on issue #9119: Update
PyArrow to 0.16.0
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on issue #9119: Update PyArrow to 0.16.0
URL: https://github.com/apache/incubator-superset/pull/9119#issuecomment-592109418
Unable to reproduce the `OSError` after rebasing. Ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9119: Update
PyArrow to 0.16.0
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9119: Update PyArrow to 0.16.0
URL: https://github.com/apache/incubator-superset/pull/9119#issuecomment-584787868
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9119?src=pr&el=h1) Report
> Merging [#9119](https://codecov.io/gh/apache/incubator-superset/pull/9119?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/607cfd1f29736590fbba397c4f8a04526be66aff?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9119?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9119 +/- ##
======================================
Coverage 59.1% 59.1%
======================================
Files 372 372
Lines 11920 11920
Branches 2917 2917
======================================
Hits 7045 7045
Misses 4693 4693
Partials 182 182
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9119?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9119/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | |
| [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/9119/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | | |
| [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9119/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | | |
| [...assets/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9119/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0xpc3RWaWV3L1RhYmxlQ29sbGVjdGlvbi50c3g=) | | |
| [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9119/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | | |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9119/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvVml6VHlwZUNvbnRyb2wuanN4) | | |
| [...set/assets/src/dashboard/util/setPeriodicRunner.js](https://codecov.io/gh/apache/incubator-superset/pull/9119/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9zZXRQZXJpb2RpY1J1bm5lci5qcw==) | | |
| [...t/assets/src/components/InfoTooltipWithTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9119/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZm9Ub29sdGlwV2l0aFRyaWdnZXIuanN4) | | |
| [.../src/dashboard/components/UndoRedoKeylisteners.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9119/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9VbmRvUmVkb0tleWxpc3RlbmVycy5qc3g=) | | |
| [...ts/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9119/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUFjdGlvbkJ1dHRvbnMuanN4) | | |
| ... and [734 more](https://codecov.io/gh/apache/incubator-superset/pull/9119/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9119?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9119?src=pr&el=footer). Last update [607cfd1...b893221](https://codecov.io/gh/apache/incubator-superset/pull/9119?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org