Plugin dependencies

[Enrico Triolo <en...@gmail.com>]

Hi all,
one of my plugins needs that the language-identifier be executed
before it, but at the moment there's no way of assuring this behaviour
(correct me if I'm wrong...).

I patched a couple of classes to allow correct ordering of execution
for plugins based on dependencies.
The patch is very simple: I just used LinkedHashMaps instead of
HashMaps in IndexingFilters and PluginRepository classes.

Since I don't know what's the politic for patches submission, I will
attach my patch to this post...

Hope it will help someone!

Enrico

Re: Plugin dependencies

[Enrico Triolo <en...@gmail.com>]

Thanks Stefan, that is indeed a good solution, but wouldn't it be more
'elegant' if nutch could guess what the correct order of execution is?
Then we could always use your suggestion in particular cases...

As you suggested, I think I will submit my patch to the jira. Thanks again!

Enrico

On 2/17/06, Stefan Groschupf <sg...@media-style.com> wrote:
> Hi,
> patches can be submitted to the jira, just create a issue and attach
> your patch.
> There are some hints for contributors in the wiki. From my experience
> carefully checking your code format. :-D
> Anyway back in the days I remember we discussed this issue and I had
> a very simple but powerful suggestion to this problem - other
> applications like jbo$$ was using also.
> What you can do is to rename the plugin folders to 01firstPlugin and
> 02secondPlugin, than sort in filelist that is used to detect and
> install the plugin in the plugin repository.
> That should already solve your proplem and you do only need to sort
> the plugin folder file list, no other changes are required - as far I
> remember correct.
>
> HTH
> Stefan
>
>
> Am 14.02.2006 um 16:51 schrieb Enrico Triolo:
>
> > Hi all,
> > one of my plugins needs that the language-identifier be executed
> > before it, but at the moment there's no way of assuring this behaviour
> > (correct me if I'm wrong...).
> >
> > I patched a couple of classes to allow correct ordering of execution
> > for plugins based on dependencies.
> > The patch is very simple: I just used LinkedHashMaps instead of
> > HashMaps in IndexingFilters and PluginRepository classes.
> >
> > Since I don't know what's the politic for patches submission, I will
> > attach my patch to this post...
> >
> > Hope it will help someone!
> >
> > Enrico
>
>

Re: Plugin dependencies

[Stefan Groschupf <sg...@media-style.com>]

Hi,
patches can be submitted to the jira, just create a issue and attach  
your patch.
There are some hints for contributors in the wiki. From my experience  
carefully checking your code format. :-D
Anyway back in the days I remember we discussed this issue and I had  
a very simple but powerful suggestion to this problem - other  
applications like jbo$$ was using also.
What you can do is to rename the plugin folders to 01firstPlugin and  
02secondPlugin, than sort in filelist that is used to detect and  
install the plugin in the plugin repository.
That should already solve your proplem and you do only need to sort  
the plugin folder file list, no other changes are required - as far I  
remember correct.

HTH
Stefan


Am 14.02.2006 um 16:51 schrieb Enrico Triolo:

> Hi all,
> one of my plugins needs that the language-identifier be executed
> before it, but at the moment there's no way of assuring this behaviour
> (correct me if I'm wrong...).
>
> I patched a couple of classes to allow correct ordering of execution
> for plugins based on dependencies.
> The patch is very simple: I just used LinkedHashMaps instead of
> HashMaps in IndexingFilters and PluginRepository classes.
>
> Since I don't know what's the politic for patches submission, I will
> attach my patch to this post...
>
> Hope it will help someone!
>
> Enrico