You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/16 07:04:38 UTC
[GitHub] [orc] dongjoon-hyun opened a new pull request #911: ORC-1000: Use Java 17 in GitHub Action
dongjoon-hyun opened a new pull request #911:
URL: https://github.com/apache/orc/pull/911
### What changes were proposed in this pull request?
This PR aims to use `Java 17` instead of `Java 17 EA`.
### Why are the changes needed?
Java 17 is finally available.
### How was this patch tested?
Pass the CIs with Java 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #911: ORC-1000: Use Java 17 in GitHub Action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #911:
URL: https://github.com/apache/orc/pull/911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #911: ORC-1000: Use Java 17 in GitHub Action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #911:
URL: https://github.com/apache/orc/pull/911#issuecomment-920808986
Thank you so much, @guiyanakuang !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #911: ORC-1000: Use Java 17 in GitHub Action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #911:
URL: https://github.com/apache/orc/pull/911#discussion_r709987653
##########
File path: java/CMakeLists.txt
##########
@@ -38,6 +38,19 @@ else()
set(JAVA_PROFILE "-Pcmake,benchmark")
endif()
+execute_process(
+ COMMAND java --add-opens java.base/java.nio=ALL-UNNAMED -version
+ WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
+ RESULT_VARIABLE RET
+ OUTPUT_QUIET
+ ERROR_QUIET)
+if(RET EQUAL 0)
+ set(JAVA_PROFILE ${JAVA_PROFILE},java17)
+ set(JAVA_TEST_PROFILE -Pcmake,java17)
+ set(ADD_OPENS --add-opens)
+ set(JAVA_NIO java.base/java.nio=ALL-UNNAMED)
+endif()
Review comment:
This is moved from [here](https://github.com/apache/orc/pull/911/files#diff-31ed790e942fadafe334a13765d2379b7b89b1c3d65a3973a94d55a77624c5dbL67-L77) and revised.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #911: ORC-1000: Use Java 17 in GitHub Action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #911:
URL: https://github.com/apache/orc/pull/911#issuecomment-920779038
cc @williamhyun and @guiyanakuang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #911: ORC-1000: Use Java 17 in GitHub Action
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #911:
URL: https://github.com/apache/orc/pull/911#issuecomment-920803108
+1 LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #911: ORC-1000: Use Java 17 in GitHub Action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #911:
URL: https://github.com/apache/orc/pull/911#discussion_r709987653
##########
File path: java/CMakeLists.txt
##########
@@ -38,6 +38,19 @@ else()
set(JAVA_PROFILE "-Pcmake,benchmark")
endif()
+execute_process(
+ COMMAND java --add-opens java.base/java.nio=ALL-UNNAMED -version
+ WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
+ RESULT_VARIABLE RET
+ OUTPUT_QUIET
+ ERROR_QUIET)
+if(RET EQUAL 0)
+ set(JAVA_PROFILE ${JAVA_PROFILE},java17)
+ set(JAVA_TEST_PROFILE -Pcmake,java17)
+ set(ADD_OPENS --add-opens)
+ set(JAVA_NIO java.base/java.nio=ALL-UNNAMED)
+endif()
Review comment:
This is moved from [here](https://github.com/apache/orc/pull/911/files#diff-31ed790e942fadafe334a13765d2379b7b89b1c3d65a3973a94d55a77624c5dbL67-L77)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org