You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tiles.apache.org by "Antonio Petrelli (JIRA)" <ji...@apache.org> on 2007/02/19 14:38:16 UTC

[jira] Created: (TILES-114) Remove JSP dependency from TilesContextFactory

Remove JSP dependency from TilesContextFactory
----------------------------------------------

                 Key: TILES-114
                 URL: https://issues.apache.org/struts/browse/TILES-114
             Project: Tiles
          Issue Type: Improvement
    Affects Versions: 2.0.0
            Reporter: Antonio Petrelli
             Fix For: 2.0.x


Currently the TilesContextFactory has a dependency on JSP, i.e. one of the two methods "createRequestContext" uses a PageContext as a parameter.
I suppose that the implementation should reside in a JSP utility class (such as JSPUtil).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TILES-114) Remove JSP dependencies from the core

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli reassigned TILES-114:
--------------------------------------

    Assignee: Antonio Petrelli

> Remove JSP dependencies from the core
> -------------------------------------
>
>                 Key: TILES-114
>                 URL: https://issues.apache.org/struts/browse/TILES-114
>             Project: Tiles
>          Issue Type: Improvement
>          Components: tiles-api, tiles-core
>    Affects Versions: 2.0.0
>            Reporter: Antonio Petrelli
>         Assigned To: Antonio Petrelli
>             Fix For: 2.0.x
>
>
> Currently some code has a dependency on JSP, i.e. one of the two methods "createRequestContext" uses a PageContext as a parameter.
> I suppose that the implementation should reside in a JSP utility class (such as JSPUtil).
> The base classes/interfaces that need to be refactored are:
> TilesContextFactory
> TilesContainer
> ComponentContext

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TILES-114) Remove JSP dependencies from the core

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli updated TILES-114:
-----------------------------------

    Component/s: tiles-api
    Description: 
Currently some code has a dependency on JSP, i.e. one of the two methods "createRequestContext" uses a PageContext as a parameter.
I suppose that the implementation should reside in a JSP utility class (such as JSPUtil).
The base classes/interfaces that need to be refactored are:
TilesContextFactory
TilesContainer
ComponentContext


  was:
Currently the TilesContextFactory has a dependency on JSP, i.e. one of the two methods "createRequestContext" uses a PageContext as a parameter.
I suppose that the implementation should reside in a JSP utility class (such as JSPUtil).

        Summary: Remove JSP dependencies from the core  (was: Remove JSP dependency from TilesContextFactory)

This issue is more generic than I thought...

> Remove JSP dependencies from the core
> -------------------------------------
>
>                 Key: TILES-114
>                 URL: https://issues.apache.org/struts/browse/TILES-114
>             Project: Tiles
>          Issue Type: Improvement
>          Components: tiles-api, tiles-core
>    Affects Versions: 2.0.0
>            Reporter: Antonio Petrelli
>             Fix For: 2.0.x
>
>
> Currently some code has a dependency on JSP, i.e. one of the two methods "createRequestContext" uses a PageContext as a parameter.
> I suppose that the implementation should reside in a JSP utility class (such as JSPUtil).
> The base classes/interfaces that need to be refactored are:
> TilesContextFactory
> TilesContainer
> ComponentContext

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (TILES-114) Remove JSP dependencies from the core

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli closed TILES-114.
----------------------------------


> Remove JSP dependencies from the core
> -------------------------------------
>
>                 Key: TILES-114
>                 URL: https://issues.apache.org/struts/browse/TILES-114
>             Project: Tiles
>          Issue Type: Improvement
>          Components: tiles-api, tiles-core
>    Affects Versions: 2.0.0
>            Reporter: Antonio Petrelli
>         Assigned To: Antonio Petrelli
>             Fix For: 2.0.2
>
>
> Currently some code has a dependency on JSP, i.e. one of the two methods "createRequestContext" uses a PageContext as a parameter.
> The base classes/interfaces that need to be refactored are:
> TilesContextFactory
> TilesContainer
> ComponentContext
> The solution seems to be the refactoring of those classes using varargs for request objects, to address cases such as:
> * request/response for requests;
> * pageContext for JSP pages.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TILES-114) Remove JSP dependencies from the core

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli updated TILES-114:
-----------------------------------

    Description: 
Currently some code has a dependency on JSP, i.e. one of the two methods "createRequestContext" uses a PageContext as a parameter.
The base classes/interfaces that need to be refactored are:
TilesContextFactory
TilesContainer
ComponentContext

The solution seems to be the refactoring of those classes using varargs for request objects, to address cases such as:
* request/response for requests;
* pageContext for JSP pages.

  was:
Currently some code has a dependency on JSP, i.e. one of the two methods "createRequestContext" uses a PageContext as a parameter.
I suppose that the implementation should reside in a JSP utility class (such as JSPUtil).
The base classes/interfaces that need to be refactored are:
TilesContextFactory
TilesContainer
ComponentContext



Added possible solution to the description. Thanks David :-)

> Remove JSP dependencies from the core
> -------------------------------------
>
>                 Key: TILES-114
>                 URL: https://issues.apache.org/struts/browse/TILES-114
>             Project: Tiles
>          Issue Type: Improvement
>          Components: tiles-api, tiles-core
>    Affects Versions: 2.0.0
>            Reporter: Antonio Petrelli
>         Assigned To: Antonio Petrelli
>             Fix For: 2.0.x
>
>
> Currently some code has a dependency on JSP, i.e. one of the two methods "createRequestContext" uses a PageContext as a parameter.
> The base classes/interfaces that need to be refactored are:
> TilesContextFactory
> TilesContainer
> ComponentContext
> The solution seems to be the refactoring of those classes using varargs for request objects, to address cases such as:
> * request/response for requests;
> * pageContext for JSP pages.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TILES-114) Remove JSP dependency from TilesContextFactory

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli updated TILES-114:
-----------------------------------

    Component/s: tiles-core

Added component reference.

> Remove JSP dependency from TilesContextFactory
> ----------------------------------------------
>
>                 Key: TILES-114
>                 URL: https://issues.apache.org/struts/browse/TILES-114
>             Project: Tiles
>          Issue Type: Improvement
>          Components: tiles-core
>    Affects Versions: 2.0.0
>            Reporter: Antonio Petrelli
>             Fix For: 2.0.x
>
>
> Currently the TilesContextFactory has a dependency on JSP, i.e. one of the two methods "createRequestContext" uses a PageContext as a parameter.
> I suppose that the implementation should reside in a JSP utility class (such as JSPUtil).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TILES-114) Remove JSP dependencies from the core

Posted by "David H. DeWolf (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/TILES-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40205 ] 

David H. DeWolf commented on TILES-114:
---------------------------------------

While I think it's a good idea to seperate out jsp support, I'd like to toss this around a little bit on the dev list and come up with a good approach.  I do  not think that introducing "utility" classes (I'm assuming that means static helpers), is the way to go.  We need to be more innovative than that, as going down that path will lead us to where we came from (a bunch of static invocations, and no extensible container environment).

> Remove JSP dependencies from the core
> -------------------------------------
>
>                 Key: TILES-114
>                 URL: https://issues.apache.org/struts/browse/TILES-114
>             Project: Tiles
>          Issue Type: Improvement
>          Components: tiles-api, tiles-core
>    Affects Versions: 2.0.0
>            Reporter: Antonio Petrelli
>             Fix For: 2.0.x
>
>
> Currently some code has a dependency on JSP, i.e. one of the two methods "createRequestContext" uses a PageContext as a parameter.
> I suppose that the implementation should reside in a JSP utility class (such as JSPUtil).
> The base classes/interfaces that need to be refactored are:
> TilesContextFactory
> TilesContainer
> ComponentContext

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TILES-114) Remove JSP dependencies from the core

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli resolved TILES-114.
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.0.x)
                   2.0.2

Refactored the API to be independent from JSP and from other technologies, by using varargs.
There is still a JSP dependency in BasicTilesContextFactory, but this will be addressed by TILES-120.

> Remove JSP dependencies from the core
> -------------------------------------
>
>                 Key: TILES-114
>                 URL: https://issues.apache.org/struts/browse/TILES-114
>             Project: Tiles
>          Issue Type: Improvement
>          Components: tiles-api, tiles-core
>    Affects Versions: 2.0.0
>            Reporter: Antonio Petrelli
>         Assigned To: Antonio Petrelli
>             Fix For: 2.0.2
>
>
> Currently some code has a dependency on JSP, i.e. one of the two methods "createRequestContext" uses a PageContext as a parameter.
> The base classes/interfaces that need to be refactored are:
> TilesContextFactory
> TilesContainer
> ComponentContext
> The solution seems to be the refactoring of those classes using varargs for request objects, to address cases such as:
> * request/response for requests;
> * pageContext for JSP pages.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.