You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "AnandInguva (via GitHub)" <gi...@apache.org> on 2023/03/15 19:43:04 UTC

[GitHub] [beam] AnandInguva commented on a diff in pull request #25785: Upgrade tox from 3.x.x to 4.x.x

AnandInguva commented on code in PR #25785:
URL: https://github.com/apache/beam/pull/25785#discussion_r1137688231


##########
sdks/python/tox.ini:
##########
@@ -64,8 +64,9 @@ commands = false {envname} is misconfigured
 
 [testenv:py{37,38,39,310}]
 commands =
+  pip install -r build-requirements.txt

Review Comment:
   sdist is getting build in a different environment compared to the `deps`.  I can remove that step and see if this works as expected. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org