You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2011/04/22 20:55:05 UTC
[jira] [Closed] (OFBIZ-4259) Add famfamfam icons has generic and
add possibility to surchage
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-4259.
----------------------------------
Resolution: Fixed
Assignee: Jacques Le Roux
Thanks Nicolas,
Your (slightly modified) patch is in trunk at r1095984
I have just added a &nbps; before the text in menus.
After Erwan's remark I wondered If I should remove the CSS on buttons. But I finally found that it was complementary. Because when no image is used on a specific button you still have the default CSS style applied (typical for Add buttons as Erwan outlined). And when no default CSS style is applied you can have an image like now shown OTTB on print button when editing an Example. So I see these 2 features as complementary for now. Maybe one day, one will replace the other, but at this stage both are welcome IMO.
BTW the famfamfam (strange name ;o) icons lib is well done and really full of possibilities...
> Add famfamfam icons has generic and add possibility to surchage
> ---------------------------------------------------------------
>
> Key: OFBIZ-4259
> URL: https://issues.apache.org/jira/browse/OFBIZ-4259
> Project: OFBiz
> Issue Type: Improvement
> Components: framework, themes
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Labels: icons, images
> Fix For: SVN trunk
>
> Attachments: Icons.jpg, OFBIZ-4259.patch, OFBIZ-4259.patch, famfamfam.zip
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons.
> If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use
> I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text.
> To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Closed] (OFBIZ-4259) Add famfamfam icons has generic
and add possibility to surchage
Posted by Nicolas Malin <ma...@librenberry.net>.
Thanks a lot Jacques for your review :)
I will propose in few days some improvement on application menu.
Nicolas
Le 22/04/2011 20:55, Jacques Le Roux (JIRA) a écrit :
> [ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Jacques Le Roux closed OFBIZ-4259.
> ----------------------------------
>
> Resolution: Fixed
> Assignee: Jacques Le Roux
>
> Thanks Nicolas,
>
> Your (slightly modified) patch is in trunk at r1095984
>
>
> I have just added a&nbps; before the text in menus.
>
> After Erwan's remark I wondered If I should remove the CSS on buttons. But I finally found that it was complementary. Because when no image is used on a specific button you still have the default CSS style applied (typical for Add buttons as Erwan outlined). And when no default CSS style is applied you can have an image like now shown OTTB on print button when editing an Example. So I see these 2 features as complementary for now. Maybe one day, one will replace the other, but at this stage both are welcome IMO.
>
> BTW the famfamfam (strange name ;o) icons lib is well done and really full of possibilities...
>
>> Add famfamfam icons has generic and add possibility to surchage
>> ---------------------------------------------------------------
>>
>> Key: OFBIZ-4259
>> URL: https://issues.apache.org/jira/browse/OFBIZ-4259
>> Project: OFBiz
>> Issue Type: Improvement
>> Components: framework, themes
>> Affects Versions: SVN trunk
>> Reporter: Nicolas Malin
>> Assignee: Jacques Le Roux
>> Priority: Minor
>> Labels: icons, images
>> Fix For: SVN trunk
>>
>> Attachments: Icons.jpg, OFBIZ-4259.patch, OFBIZ-4259.patch, famfamfam.zip
>>
>> Original Estimate: 0.5h
>> Remaining Estimate: 0.5h
>>
>> I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons.
>> If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use
>> I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text.
>> To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) )
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
--
Nicolas MALIN
Consultant
Tél : 06.17.66.40.06
Site projet : http://www.neogia.org/
-------
Société LibrenBerry
Tél : 02.48.02.56.12
Site : http://www.librenberry.net/