You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/19 06:43:29 UTC

[GitHub] [apisix] fukiki opened a new issue #4273: discuss: enrich the Available metrics of plugin prometheus

fukiki opened a new issue #4273:
URL: https://github.com/apache/apisix/issues/4273


   ### Issue description
   
   About the plugin prometheus, in the original metric data of APISIX, the number of the available metrics is limited.
   
   In some practical application scenarios, request_method and remote_addr are very useful monitoring metrics.
   
   Is there a plan to enrich the [Available metrics](https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/prometheus.md#available-metrics),such as adding remote_addr, request_method in Status codes?
   ![pe](https://user-images.githubusercontent.com/59835099/118767304-2174f500-b8b0-11eb-92b2-d37192071c0c.png)
   
   
   ### Environment
   
   apisix version (cmd: apisix version): 2.5
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] fukiki commented on issue #4273: discuss: enrich the Available metrics of plugin prometheus

Posted by GitBox <gi...@apache.org>.
fukiki commented on issue #4273:
URL: https://github.com/apache/apisix/issues/4273#issuecomment-844661512


   @spacewander Thanks for your advice. I will try it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] dmsolr commented on issue #4273: discuss: enrich the Available metrics of plugin prometheus

Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #4273:
URL: https://github.com/apache/apisix/issues/4273#issuecomment-1048602205


   I am interested in this. May I pick it up?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #4273: discuss: enrich the Available metrics of plugin prometheus

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4273:
URL: https://github.com/apache/apisix/issues/4273#issuecomment-843972735


   > This configure is only for Nginx default variables
   
   It is enough. Keep it simple stupid.
   
   > Attributes of Plugin Prometheus
   
   Should be here: https://github.com/apache/apisix/blob/83436ee125d18dff9ffa3f3daeba69548a5c3243/conf/config-default.yaml#L298 as labels are global.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #4273: discuss: enrich the Available metrics of plugin prometheus

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4273:
URL: https://github.com/apache/apisix/issues/4273#issuecomment-843853243


   We can introduce a way to dynamically configure label with Nginx var?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] fukiki commented on issue #4273: discuss: enrich the Available metrics of plugin prometheus

Posted by GitBox <gi...@apache.org>.
fukiki commented on issue #4273:
URL: https://github.com/apache/apisix/issues/4273#issuecomment-843968121


   > We can introduce a way to dynamically configure label with Nginx var?
   
   If using the way to dynamically configure label with Nginx var:
   1. This configure is only for Nginx default [variables](http://nginx.org/en/docs/varindex.htm).
   The monitoring of some business response data requires further data processing, because it is not generic.
   2. Configure the specific display item of Nginx var in Attributes of Plugin Prometheus.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org