You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/04 10:22:49 UTC
[GitHub] [shardingsphere] menghaoranss opened a new pull request #5921: Move HeartbeatDetect and Handler to cluster package of control-panel#refactor heartbeat
menghaoranss opened a new pull request #5921:
URL: https://github.com/apache/shardingsphere/pull/5921
For #5885.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #5921: Move HeartbeatDetect and Handler to cluster package of control-panel#refactor heartbeat
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5921:
URL: https://github.com/apache/shardingsphere/pull/5921#issuecomment-638781463
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5921?src=pr&el=h1) Report
> Merging [#5921](https://codecov.io/gh/apache/shardingsphere/pull/5921?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0373b4900d9da794b953eafea8ec2d136e5e974f&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `16.66%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5921?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5921 +/- ##
=========================================
Coverage 53.07% 53.08%
Complexity 438 438
=========================================
Files 1182 1182
Lines 20786 20788 +2
Branches 3742 3742
=========================================
+ Hits 11033 11036 +3
+ Misses 9068 9067 -1
Partials 685 685
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5921?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/shardingsphere/cluster/facade/ClusterFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/5921/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItZmFjYWRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2ZhY2FkZS9DbHVzdGVyRmFjYWRlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ster/heartbeat/detect/AbstractHeartbeatDetect.java](https://codecov.io/gh/apache/shardingsphere/pull/5921/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9kZXRlY3QvQWJzdHJhY3RIZWFydGJlYXREZXRlY3QuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...here/cluster/heartbeat/detect/HeartbeatDetect.java](https://codecov.io/gh/apache/shardingsphere/pull/5921/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9kZXRlY3QvSGVhcnRiZWF0RGV0ZWN0LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...ere/cluster/heartbeat/detect/HeartbeatHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/5921/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9kZXRlY3QvSGVhcnRiZWF0SGFuZGxlci5qYXZh) | `16.00% <0.00%> (ø)` | `1.00 <0.00> (?)` | |
| [...ation/core/schema/OrchestrationSchemaContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/5921/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtc2NoZW1hL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvc2NoZW1hL09yY2hlc3RyYXRpb25TY2hlbWFDb250ZXh0cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ava/org/apache/shardingsphere/proxy/Bootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/5921/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9Cb290c3RyYXAuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/cluster/heartbeat/ClusterHeartbeatInstance.java](https://codecov.io/gh/apache/shardingsphere/pull/5921/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9DbHVzdGVySGVhcnRiZWF0SW5zdGFuY2UuamF2YQ==) | `41.66% <33.33%> (-2.78%)` | `0.00 <0.00> (-1.00)` | |
| [...here/proxy/backend/schema/ProxySchemaContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/5921/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9zY2hlbWEvUHJveHlTY2hlbWFDb250ZXh0cy5qYXZh) | `77.77% <100.00%> (+2.77%)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5921?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5921?src=pr&el=footer). Last update [0373b49...96b0aee](https://codecov.io/gh/apache/shardingsphere/pull/5921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking merged pull request #5921: Move HeartbeatDetect and Handler to cluster package of control-panel#refactor heartbeat
Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #5921:
URL: https://github.com/apache/shardingsphere/pull/5921
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org