You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by vi...@apache.org on 2017/10/11 17:53:13 UTC

mesos git commit: Disabled Pylint error messages for apply-reviews support script.

Repository: mesos
Updated Branches:
  refs/heads/master d014c8230 -> a2ece4a23


Disabled Pylint error messages for apply-reviews support script.

This disables the error messages we have seen on CentOS when the
version of Python running on the machine is older than 2.7.9. The
two error messages concern only Windows, thus the support script
requires Python >= 2.7.9 on that operating system to be used.

Review: https://reviews.apache.org/r/62864/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/a2ece4a2
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/a2ece4a2
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/a2ece4a2

Branch: refs/heads/master
Commit: a2ece4a23908ae41d6a324a6161edb6ebaca1be0
Parents: d014c82
Author: Armand Grillet <ag...@mesosphere.io>
Authored: Wed Oct 11 10:53:01 2017 -0700
Committer: Vinod Kone <vi...@gmail.com>
Committed: Wed Oct 11 10:53:01 2017 -0700

----------------------------------------------------------------------
 support/apply-reviews.py | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/a2ece4a2/support/apply-reviews.py
----------------------------------------------------------------------
diff --git a/support/apply-reviews.py b/support/apply-reviews.py
index 23f2047..0ef28cb 100755
--- a/support/apply-reviews.py
+++ b/support/apply-reviews.py
@@ -165,7 +165,9 @@ def ssl_create_default_context():
     Equivalent to `ssl.create_default_context` with default arguments and
     certificate/hostname verification disabled.
     See: https://github.com/python/cpython/blob/2.7/Lib/ssl.py#L410
+    This function requires Python >= 2.7.9.
     """
+    # pylint: disable=no-member
     context = ssl.SSLContext(ssl.PROTOCOL_SSLv23)
 
     # SSLv2 considered harmful.
@@ -185,7 +187,9 @@ def ssl_create_default_context():
 
 def fetch_patch(options):
     """Fetches a patch from Review Board or GitHub."""
+    # pylint: disable=unexpected-keyword-arg
     if platform.system() == 'Windows':
+        # This call requires Python >= 2.7.9.
         response = urllib2.urlopen(
             patch_url(options),
             context=ssl_create_default_context())