You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-dev@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2012/08/28 17:29:07 UTC

[jira] [Commented] (OAK-285) Split CommitEditor into CommitEditor and Validator interfaces

    [ https://issues.apache.org/jira/browse/OAK-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443215#comment-13443215 ] 

Jukka Zitting commented on OAK-285:
-----------------------------------

The existing {{ValidatorProvider}} and {{Validator}} interfaces should already cover this. The {{ValidatingEditor}} class exists just as glue code so that we can leverage the existing {{CommitEditor}} extension point also for validators.
                
> Split CommitEditor into CommitEditor and Validator interfaces
> -------------------------------------------------------------
>
>                 Key: OAK-285
>                 URL: https://issues.apache.org/jira/browse/OAK-285
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Michael Dürig
>
> Having {{ValidatingEditor}} extend {{CommitEditor}} is a constant source of confusion since the former does not edit at all. Since it also makes sense to run validation only after all editing has taken place, I suggest to introduce a new interface {{CommitValidator}} which covers the validating aspect of a commit. Alternatively, we could of course also re-use the {{Observer}} interface here. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira