[jira] Commented: (COUCHDB-1054) Better couch_log performance

["Randall Leeds (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989551#comment-12989551 ] 

Randall Leeds commented on COUCHDB-1054:
----------------------------------------

Reviewed the patch and it looks good. Nice performance win!
Would if we added the timestamp in get_log_message?
It might make some log messages appear out of order, but it would keep the timestamp closer to the real time of the event.
Could the timestamps ever provide more information about inter-related gen_server crashes? Information which is not clear from the backtrace, the last message received, or the supervision tree?
Also, fewer io:format maybe creates less garbage?
I don't feel strongly either way, but I thought I'd pick it out and ask your opinion since the rest of the patch is unquestionably solid.

> Better couch_log performance
> ----------------------------
>
>                 Key: COUCHDB-1054
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1054
>             Project: CouchDB
>          Issue Type: Improvement
>            Reporter: Filipe Manana
>            Assignee: Filipe Manana
>         Attachments: COUCHDB-1054-2.patch, COUCHDB-1054.patch
>
>
> Building the messages to write to the console and the log file can be done outside the couch_log gen_event. This significantly increases the parallelism when many processes log messages. The following relaximation test graph shows a throughput increase using the attached patch against current trunk:
> http://graphs.mikeal.couchone.com/#/graph/0379dbdaef29b1c0fbf03421540243f7

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira