You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ap...@apache.org on 2025/03/20 16:38:40 UTC

(arrow) branch main updated: GH-45868: [C++][CI] Fix test for ambiguous initialization on C++ 20 (#45871)

This is an automated email from the ASF dual-hosted git repository.

apitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 791091efe5 GH-45868: [C++][CI] Fix test for ambiguous initialization on C++ 20 (#45871)
791091efe5 is described below

commit 791091efe56a56630c35b53dd7b66247502dcb9b
Author: Raúl Cumplido <ra...@gmail.com>
AuthorDate: Thu Mar 20 17:38:34 2025 +0100

    GH-45868: [C++][CI] Fix test for ambiguous initialization on C++ 20 (#45871)
    
    ### Rationale for this change
    
    Fails to compile on C++ 20
    
    ### What changes are included in this PR?
    
    Pass more than 2 strings so compiler correctly assumes `std::vector<std::string>` not `std::string_view`
    
    ### Are these changes tested?
    
    Via the archery job that failed
    
    ### Are there any user-facing changes?
    
    No
    * GitHub Issue: #45868
    
    Authored-by: Raúl Cumplido <ra...@gmail.com>
    Signed-off-by: Antoine Pitrou <an...@python.org>
---
 cpp/src/arrow/compute/kernels/aggregate_test.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpp/src/arrow/compute/kernels/aggregate_test.cc b/cpp/src/arrow/compute/kernels/aggregate_test.cc
index 0ed30781e7..766b5b1cd6 100644
--- a/cpp/src/arrow/compute/kernels/aggregate_test.cc
+++ b/cpp/src/arrow/compute/kernels/aggregate_test.cc
@@ -3695,8 +3695,8 @@ TEST_F(TestSkewKurtosis, Options) {
     AssertSkewKurtosisAre(type, {"[0, 1]", "[]", "[null, 2]"}, options, 0.0, -1.5);
     options.biased = false;
     AssertSkewKurtosisInvalid(type, "[0, 1]", options);
-    AssertSkewKurtosisAre(type, {"[1, 2, 3]", "[40, null]"}, options, 1.9889477403978211,
-                          3.9631931024230695);
+    AssertSkewKurtosisAre(type, {"[1, 2, 3]", "[40]", "[null]"}, options,
+                          1.9889477403978211, 3.9631931024230695);
     options.biased = true;
     options.min_count = 3;
     AssertSkewKurtosisAre(type, "[0, 1, null, 2]", options, 0.0, -1.5);