You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/01/06 14:51:34 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1689: [KYUUBI #1668] Implement ElasticSearchEventLogger to store KyuubiEvent to ElasticSearch.

pan3793 commented on pull request #1689:
URL: https://github.com/apache/incubator-kyuubi/pull/1689#issuecomment-1006651288


   Some questions:
   1. Elasticsearch has potential license issue in recent versions, v7.10.2 is the latest version released in Apache License v2.
   2. Have searched on maven central, the low level rest client `elasticsearch-rest-client` released in Apache License v2, seems OK to use, but some guy points that we need verify there is no files under other incompatible license included in jar before bundling the jar in our binary release tarball.
   3. Elasticsearch seems has different API across there major releases, e.g. 6.x, 7.x and on going 8.x, some project like Apache Flink has specific module for specific major versions, how can Kyuubi achieve that?
   4. I'm not sure if it's valued to add the integration test for this feature, if yes, maybe we can leverage Testcontainers to build such IT.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org