[GitHub] [pulsar] shibd commented on a diff in pull request #15568: [PIP-150][improve][broker] Support read the message of startMessageId position on the broker side

[GitBox <gi...@apache.org>]

shibd commented on code in PR #15568:
URL: https://github.com/apache/pulsar/pull/15568#discussion_r886637531


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -939,7 +953,7 @@ public void operationComplete() {
                 cursor.setActive();
                 // Update the ack position (ignoring entries that were written while the cursor was being created)
                 cursor.initializeCursorPosition(initialPosition == InitialPosition.Latest ? getLastPositionAndCounter()

Review Comment:
   According to the PIP. Just when `startMessageId == latest`, need judge inclusive. We can keep the `initializeCursorPosition` method unchanged and add inclusive param to the `getLastPositionAndCounter` method.
   



##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -939,7 +953,7 @@ public void operationComplete() {
                 cursor.setActive();
                 // Update the ack position (ignoring entries that were written while the cursor was being created)
                 cursor.initializeCursorPosition(initialPosition == InitialPosition.Latest ? getLastPositionAndCounter()

Review Comment:
   According to the PIP. Just when `startMessageId == latest`, need judge inclusive. We can keep the `initializeCursorPosition` method unchanged and add inclusive param to the `getLastPositionAndCounter` method.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org