You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/25 12:41:28 UTC

[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4475: rename sharding-orchestration-center-zookeeper-curator

kimmking opened a new pull request #4475: rename sharding-orchestration-center-zookeeper-curator
URL: https://github.com/apache/incubator-shardingsphere/pull/4475
 
 
   Fixes #4437.
   
   Changes proposed in this pull request:
   - Rename project name `sharding-orchestration-center-zookeeper-curator`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on issue #4475: rename sharding-orchestration-center-zookeeper-curator

Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #4475: rename sharding-orchestration-center-zookeeper-curator
URL: https://github.com/apache/incubator-shardingsphere/pull/4475#issuecomment-590910092
 
 
   > The comment `Fixes #4437.` maybe incorrect. The issue NO is not match for this PR.
   
   correct to 4473

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue #4475: rename sharding-orchestration-center-zookeeper-curator

Posted by GitBox <gi...@apache.org>.
kimmking edited a comment on issue #4475: rename sharding-orchestration-center-zookeeper-curator
URL: https://github.com/apache/incubator-shardingsphere/pull/4475#issuecomment-590910092
 
 
   > The comment `Fixes #4437.` maybe incorrect. The issue NO is not match for this PR.
   
   correct to #4473

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4475: rename sharding-orchestration-center-zookeeper-curator

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4475: rename sharding-orchestration-center-zookeeper-curator
URL: https://github.com/apache/incubator-shardingsphere/pull/4475#issuecomment-590867376
 
 
   ## Pull Request Test Coverage Report for [Build 9801](https://coveralls.io/builds/28947621)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.006%**) to **59.019%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28947621/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28947621/badge)](https://coveralls.io/builds/28947621) |
   | :-- | --: |
   | Change from base [Build 933](https://coveralls.io/builds/28944931): |  -0.006% |
   | Covered Lines: | 10614 |
   | Relevant Lines: | 17984 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on issue #4475: rename sharding-orchestration-center-zookeeper-curator

Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #4475: rename sharding-orchestration-center-zookeeper-curator
URL: https://github.com/apache/incubator-shardingsphere/pull/4475#issuecomment-590910793
 
 
   > Maybe we need to consider about this PR.
   > If using curator is named as `sharding-orchestration-center-zookeeper`, how to deal with using native zookeeper API only?
   
   We only need a zookeeper implement, so if a native zookeeper API is better than curator, it should be instead of this one in the same sub project.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking closed pull request #4475: rename sharding-orchestration-center-zookeeper-curator

Posted by GitBox <gi...@apache.org>.
kimmking closed pull request #4475: rename sharding-orchestration-center-zookeeper-curator
URL: https://github.com/apache/incubator-shardingsphere/pull/4475
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4475: rename sharding-orchestration-center-zookeeper-curator

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4475: rename sharding-orchestration-center-zookeeper-curator
URL: https://github.com/apache/incubator-shardingsphere/pull/4475#issuecomment-590867376
 
 
   ## Pull Request Test Coverage Report for [Build 1886](https://coveralls.io/builds/28947638)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **59.025%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28947638/badge)](https://coveralls.io/builds/28947638) |
   | :-- | --: |
   | Change from base [Build 933](https://coveralls.io/builds/28944931): |  0.0% |
   | Covered Lines: | 10615 |
   | Relevant Lines: | 17984 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue #4475: rename sharding-orchestration-center-zookeeper-curator

Posted by GitBox <gi...@apache.org>.
kimmking edited a comment on issue #4475: rename sharding-orchestration-center-zookeeper-curator
URL: https://github.com/apache/incubator-shardingsphere/pull/4475#issuecomment-590910793
 
 
   > Maybe we need to consider about this PR.
   > If using curator is named as `sharding-orchestration-center-zookeeper`, how to deal with using native zookeeper API only?
   
   We only need one zookeeper implement, so if a native zookeeper API is better than curator, it should be instead of this one in the same sub project.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4475: rename sharding-orchestration-center-zookeeper-curator

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4475: rename sharding-orchestration-center-zookeeper-curator
URL: https://github.com/apache/incubator-shardingsphere/pull/4475#issuecomment-590867376
 
 
   ## Pull Request Test Coverage Report for [Build 9799](https://coveralls.io/builds/28946546)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.006%**) to **59.019%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28946546/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28946546/badge)](https://coveralls.io/builds/28946546) |
   | :-- | --: |
   | Change from base [Build 933](https://coveralls.io/builds/28944931): |  -0.006% |
   | Covered Lines: | 10614 |
   | Relevant Lines: | 17984 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4475: rename sharding-orchestration-center-zookeeper-curator

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4475: rename sharding-orchestration-center-zookeeper-curator
URL: https://github.com/apache/incubator-shardingsphere/pull/4475#issuecomment-590863739
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4475?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@c7d9c1b`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4475/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4475?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #4475   +/-   ##
   =========================================
     Coverage          ?   55.36%           
     Complexity        ?      330           
   =========================================
     Files             ?      952           
     Lines             ?    17984           
     Branches          ?     3384           
   =========================================
     Hits              ?     9957           
     Misses            ?     7382           
     Partials          ?      645
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4475?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ance/handler/CuratorZookeeperExceptionHandler.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4475/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL2hhbmRsZXIvQ3VyYXRvclpvb2tlZXBlckV4Y2VwdGlvbkhhbmRsZXIuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...tion/center/instance/CuratorZookeeperInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4475/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0N1cmF0b3Jab29rZWVwZXJJbnN0YW5jZS5qYXZh) | `38.13% <ø> (ø)` | `0 <0> (?)` | |
   | [...estration/center/instance/ZookeeperProperties.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4475/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL1pvb2tlZXBlclByb3BlcnRpZXMuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (?)` | |
   | [...ation/center/instance/ZookeeperPropertiesEnum.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4475/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL1pvb2tlZXBlclByb3BlcnRpZXNFbnVtLmphdmE=) | `100% <ø> (ø)` | `0 <0> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4475?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4475?src=pr&el=footer). Last update [c7d9c1b...0b28c28](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4475?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services