Re: [PR] feat: support NullType output types in codegen dispatch [datafusion-comet]

["grorge123 (via GitHub)" <gi...@apache.org>]

grorge123 commented on PR #5526:
URL: https://github.com/apache/datafusion-comet/pull/5526#issuecomment-5520021530

   Beyond the five cases above, this revision adds `CometNullTypeCompositionSuite`, a differential sweep of the admitted shape space: every non-foldable NullType producer (`transform(array(id), x -> NULL)`, `map(id, NULL)`, `transform_values(map(), ...)`, `map_entries(map(id, NULL))`, `named_struct(..., NULL)`, an all-NULL `aggregate`) under every consumer, operator and nesting container Spark accepts, across ANSI on/off, a nullable non-deterministic wrapper, and native columnar-to-row on/off, comparing Comet with Spark.
   
   The non-NullType flavour of the same item-field problem (`slice(map_entries(map(k, v)), ...)`, `slice(reverse(arrays_zip(...)))`, the #4789 nested-nullability contract) reproduces on main and is outside this PR's admission. The one native gap the sweep tolerates is also pre-existing: Comet's row shuffle writer has no case for a `Null` struct field (`Unsupported data type of struct field: Null`), matched by signature so every other failure stays red.
   
   Assisted-by: Claude Code (claude-fable-5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org