You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Lukas Theussl (JIRA)" <ji...@codehaus.org> on 2009/05/07 12:15:44 UTC

[jira] Created: (DOXIA-316) Backward issue: depth counting has changed in TOC macro

Backward issue: depth counting has changed in TOC macro
-------------------------------------------------------

                 Key: DOXIA-316
                 URL: http://jira.codehaus.org/browse/DOXIA-316
             Project: Maven Doxia
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.1
            Reporter: Lukas Theussl


It seems that the definition of "depth" has changed in the TOC macro. For the following apt source:

{noformat}

%{toc|section=1|fromDepth=1|toDepth=1}

Section
* Sub-section 1
* Sub-section 2

{noformat}

Doxia 1.0 puts the list of sub-sections into the toc, Doxia 1.1 only the section.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (DOXIA-316) Backward issue: wrong section counting in TOC macro

Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/DOXIA-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukas Theussl closed DOXIA-316.
-------------------------------

    Resolution: Fixed

Fixed. Depth=1 is section, depth=2 is sub-section, etc, as documented.

> Backward issue: wrong section counting in TOC macro
> ---------------------------------------------------
>
>                 Key: DOXIA-316
>                 URL: http://jira.codehaus.org/browse/DOXIA-316
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0
>            Reporter: Lukas Theussl
>            Assignee: Lukas Theussl
>             Fix For: 1.1.1
>
>
> It seems that the definition of "depth" has changed in the TOC macro. For the following apt source:
> {noformat}
> %{toc|section=1|fromDepth=1|toDepth=1}
> Section
> * Sub-section 1
> * Sub-section 2
> {noformat}
> Doxia 1.0 puts the list of sub-sections into the toc, Doxia 1.1 only the section.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (DOXIA-316) Backward issue: depth counting has changed in TOC macro

Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/DOXIA-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukas Theussl reopened DOXIA-316:
---------------------------------


Re-opening as this should really be counted as a bug in Doxia 1.0 and not a regression IMO.  The problem is actually with the section counting, not the depth. Eg site-plugin-2.0 generates two different tocs for the following:

{noformat}
%{toc|section=1|fromDepth=1|toDepth=1}
%{toc|section=2|fromDepth=1|toDepth=1}

Section 1

* Sub-section 1.1
* Sub-section 1.2

Section 2

* Sub-section 2.1
* Sub-section 2.2
{noformat}

The toc for section 1 contains the two sub-sections, while the one for section 2 contains only the section.

Now I think that the current behavior of doxia 1.1 is correct, and consistent with the docs, but the problem is backward compatibility. All pages that contain a toc for a first section will be broken. So the question is: to fix or not to fix?

> Backward issue: depth counting has changed in TOC macro
> -------------------------------------------------------
>
>                 Key: DOXIA-316
>                 URL: http://jira.codehaus.org/browse/DOXIA-316
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0
>            Reporter: Lukas Theussl
>            Assignee: Lukas Theussl
>             Fix For: 1.1.1
>
>
> It seems that the definition of "depth" has changed in the TOC macro. For the following apt source:
> {noformat}
> %{toc|section=1|fromDepth=1|toDepth=1}
> Section
> * Sub-section 1
> * Sub-section 2
> {noformat}
> Doxia 1.0 puts the list of sub-sections into the toc, Doxia 1.1 only the section.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (DOXIA-316) Backward issue: wrong section counting in TOC macro

Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/DOXIA-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukas Theussl updated DOXIA-316:
--------------------------------

    Affects Version/s:     (was: 1.1)
                       1.0
              Summary: Backward issue: wrong section counting in TOC macro  (was: Backward issue: depth counting has changed in TOC macro)

> Backward issue: wrong section counting in TOC macro
> ---------------------------------------------------
>
>                 Key: DOXIA-316
>                 URL: http://jira.codehaus.org/browse/DOXIA-316
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0
>            Reporter: Lukas Theussl
>            Assignee: Lukas Theussl
>             Fix For: 1.1.1
>
>
> It seems that the definition of "depth" has changed in the TOC macro. For the following apt source:
> {noformat}
> %{toc|section=1|fromDepth=1|toDepth=1}
> Section
> * Sub-section 1
> * Sub-section 2
> {noformat}
> Doxia 1.0 puts the list of sub-sections into the toc, Doxia 1.1 only the section.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (DOXIA-316) Backward issue: depth counting has changed in TOC macro

Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/DOXIA-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukas Theussl closed DOXIA-316.
-------------------------------

         Assignee: Lukas Theussl
       Resolution: Fixed
    Fix Version/s: 1.1.1

Fixed in [r772599|http://svn.apache.org/viewvc?view=rev&revision=772599].

> Backward issue: depth counting has changed in TOC macro
> -------------------------------------------------------
>
>                 Key: DOXIA-316
>                 URL: http://jira.codehaus.org/browse/DOXIA-316
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1
>            Reporter: Lukas Theussl
>            Assignee: Lukas Theussl
>             Fix For: 1.1.1
>
>
> It seems that the definition of "depth" has changed in the TOC macro. For the following apt source:
> {noformat}
> %{toc|section=1|fromDepth=1|toDepth=1}
> Section
> * Sub-section 1
> * Sub-section 2
> {noformat}
> Doxia 1.0 puts the list of sub-sections into the toc, Doxia 1.1 only the section.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira