You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Weston M. Price (Created) (JIRA)" <ji...@apache.org> on 2012/01/17 15:57:39 UTC
[jira] [Created] (QPID-3763) AMQConnectionDelegate_0_10 incorrectly
prints password to log file
AMQConnectionDelegate_0_10 incorrectly prints password to log file
------------------------------------------------------------------
Key: QPID-3763
URL: https://issues.apache.org/jira/browse/QPID-3763
Project: Qpid
Issue Type: Bug
Components: Java Client
Environment: All OS platforms.
Reporter: Weston M. Price
Assignee: Weston M. Price
Priority: Critical
The AMQConnectionDelegate_0_10 prints password information to the log file. This should be replaced with the standard '******' pattern. Also, I think we should go through the JMS client and determine if this is being done anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3763) AMQConnectionDelegate_0_10
incorrectly prints password to log file
Posted by "Weston M. Price (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191268#comment-13191268 ]
Weston M. Price commented on QPID-3763:
---------------------------------------
Hi Alex,
Typically I believe masking never uses the exact number of characters from the password as this would give an indication of exactly how long the password is. Also, I believe some form of mask makes sense being that if some form of password based auth is being used, people would expect to see the standard '******' printed to the logs.
> AMQConnectionDelegate_0_10 incorrectly prints password to log file
> ------------------------------------------------------------------
>
> Key: QPID-3763
> URL: https://issues.apache.org/jira/browse/QPID-3763
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Environment: All OS platforms.
> Reporter: Weston M. Price
> Assignee: Weston M. Price
> Priority: Critical
> Fix For: 0.15
>
> Attachments: QPID-3763.patch
>
>
> The AMQConnectionDelegate_0_10 prints password information to the log file. This should be replaced with the standard '******' pattern. Also, I think we should go through the JMS client and determine if this is being done anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3763) AMQConnectionDelegate_0_10
incorrectly prints password to log file
Posted by "Weston M. Price (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Weston M. Price resolved QPID-3763.
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.15
Fixed with attached patch.
> AMQConnectionDelegate_0_10 incorrectly prints password to log file
> ------------------------------------------------------------------
>
> Key: QPID-3763
> URL: https://issues.apache.org/jira/browse/QPID-3763
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Environment: All OS platforms.
> Reporter: Weston M. Price
> Assignee: Weston M. Price
> Priority: Critical
> Fix For: 0.15
>
> Attachments: QPID-3763.patch
>
>
> The AMQConnectionDelegate_0_10 prints password information to the log file. This should be replaced with the standard '******' pattern. Also, I think we should go through the JMS client and determine if this is being done anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3763) AMQConnectionDelegate_0_10 incorrectly
prints password to log file
Posted by "Weston M. Price (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Weston M. Price updated QPID-3763:
----------------------------------
Attachment: QPID-3763.patch
Added standard "******" pattern for password in log file.
> AMQConnectionDelegate_0_10 incorrectly prints password to log file
> ------------------------------------------------------------------
>
> Key: QPID-3763
> URL: https://issues.apache.org/jira/browse/QPID-3763
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Environment: All OS platforms.
> Reporter: Weston M. Price
> Assignee: Weston M. Price
> Priority: Critical
> Attachments: QPID-3763.patch
>
>
> The AMQConnectionDelegate_0_10 prints password information to the log file. This should be replaced with the standard '******' pattern. Also, I think we should go through the JMS client and determine if this is being done anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3763) AMQConnectionDelegate_0_10
incorrectly prints password to log file
Posted by "Rajith Attapattu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191277#comment-13191277 ]
Rajith Attapattu commented on QPID-3763:
----------------------------------------
Alex,
I also agree with Weston. It's better to not give any hints as to what the password length etc..
Usually the **** seems pretty standard in logs etc..
Regards,
Rajith
> AMQConnectionDelegate_0_10 incorrectly prints password to log file
> ------------------------------------------------------------------
>
> Key: QPID-3763
> URL: https://issues.apache.org/jira/browse/QPID-3763
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Environment: All OS platforms.
> Reporter: Weston M. Price
> Assignee: Weston M. Price
> Priority: Critical
> Fix For: 0.15
>
> Attachments: QPID-3763.patch
>
>
> The AMQConnectionDelegate_0_10 prints password information to the log file. This should be replaced with the standard '******' pattern. Also, I think we should go through the JMS client and determine if this is being done anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3763) AMQConnectionDelegate_0_10
incorrectly prints password to log file
Posted by "Alex Rudyy (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191251#comment-13191251 ]
Alex Rudyy commented on QPID-3763:
----------------------------------
Hi Weston,
IMHO, with current implementation seeing 6 '*' characters for a password when Kerberos (or any other non-password) authentication is used could be a bit misleading.
I would say that it could be more clear to either
mask each password characters with "*" char and display the exact number of "*" characters as the number of characters in password
or stop printing password and any password mask characters.
What do you think about it?
> AMQConnectionDelegate_0_10 incorrectly prints password to log file
> ------------------------------------------------------------------
>
> Key: QPID-3763
> URL: https://issues.apache.org/jira/browse/QPID-3763
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Environment: All OS platforms.
> Reporter: Weston M. Price
> Assignee: Weston M. Price
> Priority: Critical
> Fix For: 0.15
>
> Attachments: QPID-3763.patch
>
>
> The AMQConnectionDelegate_0_10 prints password information to the log file. This should be replaced with the standard '******' pattern. Also, I think we should go through the JMS client and determine if this is being done anywhere else.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org