You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by "MikeAT (via GitHub)" <gi...@apache.org> on 2025/01/03 10:17:50 UTC
[PR] RcodeZero Driver: fix issue when adding a reocrd where a record with a different type already exists [libcloud]
MikeAT opened a new pull request, #2038:
URL: https://github.com/apache/libcloud/pull/2038
## RcodeZero: Bugfix when adding a reocrd where a record with a different type already exists
### Description
The RcodeZero driver generated broken API-Requests when adding records with different type (eg. adding an AAAA record to an existing A record). This PR fixes this issue:
### Status
Done, ready for review
### Checklist (tick everything that applies)
- [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [X] Documentation
- [X] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RcodeZero Driver: fix issue when adding a reocrd where a record with a different type already exists [libcloud]
Posted by "MikeAT (via GitHub)" <gi...@apache.org>.
MikeAT commented on PR #2038:
URL: https://github.com/apache/libcloud/pull/2038#issuecomment-2569059239
Could you please merge this [documentation PR](https://github.com/apache/libcloud/pull/2032) too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RcodeZero Driver: fix issue when adding a reocrd where a record with a different type already exists [libcloud]
Posted by "Kami (via GitHub)" <gi...@apache.org>.
Kami commented on PR #2038:
URL: https://github.com/apache/libcloud/pull/2038#issuecomment-2692816712
@MikeAT Thanks for the contribution.
Would it be possible to add a unit test case for this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RcodeZero Driver: fix issue when adding a reocrd where a record with a different type already exists [libcloud]
Posted by "MikeAT (via GitHub)" <gi...@apache.org>.
MikeAT commented on PR #2038:
URL: https://github.com/apache/libcloud/pull/2038#issuecomment-2693972369
Hi @Kami,
sorry, I forgot to commit the API v2 tests. And I added the regression test for the fixed bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RcodeZero Driver: fix issue when adding a record where a record with a different type already exists [libcloud]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2038:
URL: https://github.com/apache/libcloud/pull/2038#issuecomment-3884618373
## [Codecov](https://app.codecov.io/gh/apache/libcloud/pull/2038?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `95.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 83.35%. Comparing base ([`5e6b553`](https://app.codecov.io/gh/apache/libcloud/commit/5e6b55390cabb260d27b4107130e7213ff4d0295?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5b56d39`](https://app.codecov.io/gh/apache/libcloud/commit/5b56d3992ce5e6a433372615c32aebdb173adce2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/libcloud/pull/2038?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [libcloud/dns/drivers/rcodezero.py](https://app.codecov.io/gh/apache/libcloud/pull/2038?src=pr&el=tree&filepath=libcloud%2Fdns%2Fdrivers%2Frcodezero.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliY2xvdWQvZG5zL2RyaXZlcnMvcmNvZGV6ZXJvLnB5) | 66.67% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/libcloud/pull/2038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## trunk #2038 +/- ##
==========================================
- Coverage 83.35% 83.35% -0.00%
==========================================
Files 353 353
Lines 81848 81858 +10
Branches 8998 8999 +1
==========================================
+ Hits 68224 68232 +8
- Misses 10797 10798 +1
- Partials 2827 2828 +1
```
| [Files with missing lines](https://app.codecov.io/gh/apache/libcloud/pull/2038?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [libcloud/test/dns/test\_rcodezero.py](https://app.codecov.io/gh/apache/libcloud/pull/2038?src=pr&el=tree&filepath=libcloud%2Ftest%2Fdns%2Ftest_rcodezero.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliY2xvdWQvdGVzdC9kbnMvdGVzdF9yY29kZXplcm8ucHk=) | `100.00% <100.00%> (ø)` | |
| [libcloud/dns/drivers/rcodezero.py](https://app.codecov.io/gh/apache/libcloud/pull/2038?src=pr&el=tree&filepath=libcloud%2Fdns%2Fdrivers%2Frcodezero.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliY2xvdWQvZG5zL2RyaXZlcnMvcmNvZGV6ZXJvLnB5) | `70.10% <66.67%> (-0.73%)` | :arrow_down: |
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RcodeZero Driver: fix issue when adding a record where a record with a different type already exists [libcloud]
Posted by "micafer (via GitHub)" <gi...@apache.org>.
micafer merged PR #2038:
URL: https://github.com/apache/libcloud/pull/2038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RcodeZero Driver: fix issue when adding a reocrd where a record with a different type already exists [libcloud]
Posted by "Kami (via GitHub)" <gi...@apache.org>.
Kami commented on PR #2038:
URL: https://github.com/apache/libcloud/pull/2038#issuecomment-2693531763
@MikeAT The documentation PR has been merged.
It looks like the existing tests are failing. It would be great if you could look into that (you likely need to add mock response fixtures for v2 API responses and implement corresponding methods on the MockHttp class) and add a (regression) test case for a bug this PR is fixing.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org