You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/03/28 21:14:57 UTC

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3932: Cleanup logic in JavaInstanceRunnable close method

jerrypeng commented on a change in pull request #3932: Cleanup logic in JavaInstanceRunnable close method
URL: https://github.com/apache/pulsar/pull/3932#discussion_r270201841
 
 

 ##########
 File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
 ##########
 @@ -457,19 +457,20 @@ private Record readInput() {
     }
 
     @Override
-    public void close() {
+    synchronized public void close() {
 
 Review comment:
   can you add a comment to why this method needs to be synchronized for future reference

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services