You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/05 23:19:31 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32445: [SPARK-35323][BUILD] Remove unused libraries from LICENSE-binary

dongjoon-hyun commented on a change in pull request #32445:
URL: https://github.com/apache/spark/pull/32445#discussion_r626978822



##########
File path: LICENSE-binary
##########
@@ -261,7 +260,6 @@ net.sf.supercsv:super-csv
 org.apache.arrow:arrow-format
 org.apache.arrow:arrow-memory
 org.apache.arrow:arrow-vector
-org.apache.commons:commons-configuration2

Review comment:
       This is not used in `hadoop-2.7`. In this PR, all removal is verified like the following. And, the library used by hadoop-2.7 are not included.
   
   **BRANCH-3.1**
   ```
   deps:branch-3.1 $ git grep commons-configuration2
   spark-deps-hadoop-3.2-hive-2.3:commons-configuration2/2.1.1//commons-configuration2-2.1.1.jar
   ```
   
   **MASTER**
   ```
   deps:master $ git grep commons-configuration2
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org