You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/08/31 15:43:13 UTC

[PR] fix(credential): serialize Tencent client lookup with invalidation [rocketmq-dashboard]

yyqdbngt opened a new pull request, #2858:
URL: https://github.com/apache/rocketmq-dashboard/pull/2858

   ## Summary
   - Move the `TencentClientFactory.client()` fast-path cache read inside the same monitor that `invalidateCredential()` holds
   - Add a package-private `cachedClient` seam and a regression test that suspends a lookup between the cache read and the return while a concurrent credential rotation runs
   
   ## Why
   The cached-client read ran outside the invalidation lock: a thread suspended between the map read and the return could hand out a client that a concurrent credential rotation (triggered on credential update/delete by `CloudCredentialService`) had just evicted. That client still carries the replaced secret, so a request signed seconds after a rotation fails with a confusing "credential is invalid" even though the new credential is configured.
   
   ## Testing
   - `mvn -Dtest=TencentClientFactoryTest test` → Tests run: 5, Failures: 0, Errors: 0 (4 existing + 1 new regression test)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(credential): serialize Tencent client lookup with invalidation [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] closed pull request #2858: fix(credential): serialize Tencent client lookup with invalidation
URL: https://github.com/apache/rocketmq-dashboard/pull/2858


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(credential): serialize Tencent client lookup with invalidation [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #2858:
URL: https://github.com/apache/rocketmq-dashboard/pull/2858#issuecomment-5577097082

   This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org