You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Kishor Gollapalliwar <ki...@gmail.com> on 2020/01/10 05:59:52 UTC

Re: Review Request 71974: RANGER-2690: Default service display name is not getting set for Tag service

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71974/
-----------------------------------------------------------

(Updated Jan. 10, 2020, 5:59 a.m.)


Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.


Bugs: RANGER-2690
    https://issues.apache.org/jira/browse/RANGER-2690


Repository: ranger


Description
-------

When a service is created, corresponding tag is also created (assume "ranger.tagservice.auto.create=true"). The tag created does not have Display Name associated with it. The tag displayName should be same as name.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 6d5d8f991 


Diff: https://reviews.apache.org/r/71974/diff/1/


Testing
-------

Created services with displayName and varified
Created services without displayName and varified
Updated services and varified

Created tag with displayName and varified
Created tag without displayName and varified
Updated tag and varified


Thanks,

Kishor Gollapalliwar


Re: Review Request 71974: RANGER-2690: Default service display name is not getting set for Tag service

Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71974/#review219204
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On Jan. 10, 2020, 5:59 a.m., Kishor Gollapalliwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71974/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2020, 5:59 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and Pradeep Agrawal.
> 
> 
> Bugs: RANGER-2690
>     https://issues.apache.org/jira/browse/RANGER-2690
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> When a service is created, corresponding tag is also created (assume "ranger.tagservice.auto.create=true"). The tag created does not have Display Name associated with it. The tag displayName should be same as name.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 6d5d8f991 
> 
> 
> Diff: https://reviews.apache.org/r/71974/diff/1/
> 
> 
> Testing
> -------
> 
> Created services with displayName and varified
> Created services without displayName and varified
> Updated services and varified
> 
> Created tag with displayName and varified
> Created tag without displayName and varified
> Updated tag and varified
> 
> 
> Thanks,
> 
> Kishor Gollapalliwar
> 
>