You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/10 00:13:45 UTC
[GitHub] [skywalking] codelipenghui commented on a change in pull request #6918: fix pulsar plugin message listener error with multi partitions topic
codelipenghui commented on a change in pull request #6918:
URL: https://github.com/apache/skywalking/pull/6918#discussion_r628963487
##########
File path: test/plugin/scenarios/pulsar-scenario/src/main/java/test/apache/skywalking/apm/testcase/pulsar/controller/CaseController.java
##########
@@ -48,10 +53,25 @@
@RequestMapping("/pulsar-case")
@ResponseBody
- public String pulsarCase() throws PulsarClientException, InterruptedException {
+ public String pulsarCase() {
- String topic = "test";
+ String topicOnePartition = "test";
+ String topicMultiPartition = "testMultiPartition";
+ try {
+ createTopic(topicOnePartition, 1);
Review comment:
From this change, the test only covered the partitioned topic, we can call create topic only for the partitions > 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org