[GitHub] [superset] john-bodley commented on a diff in pull request #24121: fix: Address regression introduced in #22853

["john-bodley (via GitHub)" <gi...@apache.org>]

john-bodley commented on code in PR #24121:
URL: https://github.com/apache/superset/pull/24121#discussion_r1198308942


##########
superset/connectors/sqla/models.py:
##########
@@ -434,7 +461,7 @@ def get_sqla_col(
             expression = template_processor.process_template(expression)
 
         sqla_col: ColumnClause = literal_column(expression)
-        return self.table.make_sqla_column_compatible(sqla_col, label)
+        return self.database.make_sqla_column_compatible(sqla_col, label)

Review Comment:
   Line #470 references `self.table` but includes a check to that it's truthy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org