You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/02 20:51:41 UTC

[GitHub] [airflow] ConstantinoSchillebeeckx opened a new issue #14569: Connection uri does not allow foward slash

ConstantinoSchillebeeckx opened a new issue #14569:
URL: https://github.com/apache/airflow/issues/14569


   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the following questions.
   Don't worry if they're not all applicable; just try to include what you can :-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   <!--
   
   IMPORTANT!!!
   
   PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
   NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
   
   PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
   
   Please complete the next sections or the issue will be closed.
   These questions are the first thing we need to know to understand the context.
   
   -->
   
   **Apache Airflow version**: 2.0.1
   
   **What happened**:
   
   I've configured remote logging to AWS S3 and have configured `AIRFLOW__LOGGING__REMOTE_LOG_CONN_ID` through an ENV like:
   ```
   AIRFLOW_CONN_S3_LOG_CONN_ID=s3://${AWS_ACCESS_KEY_ID}:${AWS_SECRET_ACCESS_KEY}@${AWS_S3_BUCKET_NAME}
   ```
   
   When `AWS_SECRET_ACCESS_KEY` has a forward slash in it, the class constructor fails.
   
   <!-- (please include exact error messages if you can) -->
   
   
   **How to reproduce it**:
   ```
   from airflow.models.connection import Connection
   uri = "s3://some_aws_access_key:secret_key123/321asdf@bucket_name"
   c = Connection(uri=uri)
   ```
   Results in 
   ```
   ValueError: invalid literal for int() with base 10: 'secret_key123'
   ```
   
   **Anything else we need to know**:
   
   Looks like this may have been [previously identified](https://issues.apache.org/jira/browse/AIRFLOW-2963).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed issue #14569: Connection uri does not allow foward slash

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #14569:
URL: https://github.com/apache/airflow/issues/14569


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on issue #14569: Connection uri does not allow foward slash

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #14569:
URL: https://github.com/apache/airflow/issues/14569#issuecomment-789241403


   `%2f` in this case -- `s3://some_aws_access_key:secret_key123%2f321asdf@bucket_name`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ConstantinoSchillebeeckx commented on issue #14569: Connection uri does not allow foward slash

Posted by GitBox <gi...@apache.org>.
ConstantinoSchillebeeckx commented on issue #14569:
URL: https://github.com/apache/airflow/issues/14569#issuecomment-789247231


   Ah it's in the [docs](https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html#handling-of-special-characters-in-connection-params); thank you both so much.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #14569: Connection uri does not allow foward slash

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #14569:
URL: https://github.com/apache/airflow/issues/14569#issuecomment-789217899


   Please take a look at the URI specification.You must urlencode forward slash.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org