You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@texera.apache.org by "gracecluvohio (via GitHub)" <gi...@apache.org> on 2025/10/15 03:57:59 UTC
[PR] Fix file upload section border [texera]
gracecluvohio opened a new pull request, #3906:
URL: https://github.com/apache/texera/pull/3906
### Purpose of the PR
The file upload section border was too short before when its panels were expanded, so the file section now scrolls on overflow.
### Summary of changes
- added scrolling to the file section
### Demo
Before
<img width="1710" height="988" alt="Screenshot 2025-10-14 at 8 56 54 PM" src="https://github.com/user-attachments/assets/e5d40580-db62-4c6b-940f-06f05d5f0d77" />
After
<img width="1710" height="988" alt="Screenshot 2025-10-14 at 8 56 23 PM" src="https://github.com/user-attachments/assets/fd50d907-c3dc-4dd2-b1eb-43dbdf82caf3" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): file upload section border [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #3906:
URL: https://github.com/apache/texera/pull/3906#issuecomment-3404673695
I don't think the issue is properly linked. please use one of those keywords for automation https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): file upload section border [texera]
Posted by "gracecluvohio (via GitHub)" <gi...@apache.org>.
gracecluvohio commented on PR #3906:
URL: https://github.com/apache/texera/pull/3906#issuecomment-3407410175
> I don't think the issue is properly linked. please use one of those keywords for automation https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
Hi! It's not intended to close the issue. I've changed the wording to reflect that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): file upload section border [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #3906:
URL: https://github.com/apache/texera/pull/3906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): file upload section border [texera]
Posted by "gracecluvohio (via GitHub)" <gi...@apache.org>.
gracecluvohio commented on code in PR #3906:
URL: https://github.com/apache/texera/pull/3906#discussion_r2434755940
##########
frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/dataset-detail.component.html:
##########
@@ -206,206 +206,208 @@ <h3 class="file-title">
nzTheme="outline"></i>
</div>
</nz-resize-handle>
- <div class="right-sider">
- <nz-collapse nzGhost>
- <nz-collapse-panel
- nzHeader="Current Versions"
- nzActive="true">
- <div class="version-storage">
- <h6 style="font-weight: lighter; font-size: 0.9em">Choose a Version:</h6>
- <div class="select-and-button-container">
- <nz-select
- nzShowSearch
- nzAllowClear
- nzPlaceHolder="Select a version"
- (ngModelChange)="onVersionSelected($event)"
- [(ngModel)]="selectedVersion">
- <nz-option
- *ngFor="let version of versions"
- [nzValue]="version"
- [nzLabel]="version.name"></nz-option>
- </nz-select>
- <button
- nz-button
- nz-tooltip="Download Dataset"
- (click)="onClickDownloadVersionAsZip()"
- *ngIf="selectedVersion"
- [disabled]="!isLogin || !isDownloadAllowed()"
- class="spaced-button">
- <i
- nz-icon
- nzType="download"
- nzTheme="outline"></i>
- </button>
- </div>
- <ng-container *ngIf="selectedVersion">
- <div class="version-size">
- <i
- nz-icon
- nzType="database"
- nzTheme="outline"
- class="icon-database"></i>
- Version Size: {{ formatSize(currentDatasetVersionSize) }}
- </div>
- <div
- *ngIf="selectedVersionCreationTime"
- class="version-date">
- <i
- nz-icon
- nzType="calendar"
- nzTheme="outline"
- class="icon-database"></i>
- Created at: {{ selectedVersionCreationTime }}
+ <div class="right-sider-scrolling-container">
+ <div class="right-sider">
Review Comment:
Actually you're right! Removed the extra wrapper since it's unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): file upload section border [texera]
Posted by "gracecluvohio (via GitHub)" <gi...@apache.org>.
gracecluvohio commented on PR #3906:
URL: https://github.com/apache/texera/pull/3906#issuecomment-3404506748
> Thanks for the PR! It’s a bit hard to see what changed—the diff includes about 200 lines. Also, the demo video in the description isn’t showing. You could add a blank line before and after the link, it should be displayed properly.
Hi! Yes, unfortunately the changes aren't very clear in the HTML file because the change involves a div wrapping around some of the HTML, so formatting caused all those lines to be indented. However the only change in the HTML is the wrapping div called .right-sider-scrolling-container.
Thank you, updated the description! The videos should be showing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): file upload section border [texera]
Posted by "gracecluvohio (via GitHub)" <gi...@apache.org>.
gracecluvohio commented on code in PR #3906:
URL: https://github.com/apache/texera/pull/3906#discussion_r2434535465
##########
frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/dataset-detail.component.html:
##########
@@ -206,206 +206,208 @@ <h3 class="file-title">
nzTheme="outline"></i>
</div>
</nz-resize-handle>
- <div class="right-sider">
- <nz-collapse nzGhost>
- <nz-collapse-panel
- nzHeader="Current Versions"
- nzActive="true">
- <div class="version-storage">
- <h6 style="font-weight: lighter; font-size: 0.9em">Choose a Version:</h6>
- <div class="select-and-button-container">
- <nz-select
- nzShowSearch
- nzAllowClear
- nzPlaceHolder="Select a version"
- (ngModelChange)="onVersionSelected($event)"
- [(ngModel)]="selectedVersion">
- <nz-option
- *ngFor="let version of versions"
- [nzValue]="version"
- [nzLabel]="version.name"></nz-option>
- </nz-select>
- <button
- nz-button
- nz-tooltip="Download Dataset"
- (click)="onClickDownloadVersionAsZip()"
- *ngIf="selectedVersion"
- [disabled]="!isLogin || !isDownloadAllowed()"
- class="spaced-button">
- <i
- nz-icon
- nzType="download"
- nzTheme="outline"></i>
- </button>
- </div>
- <ng-container *ngIf="selectedVersion">
- <div class="version-size">
- <i
- nz-icon
- nzType="database"
- nzTheme="outline"
- class="icon-database"></i>
- Version Size: {{ formatSize(currentDatasetVersionSize) }}
- </div>
- <div
- *ngIf="selectedVersionCreationTime"
- class="version-date">
- <i
- nz-icon
- nzType="calendar"
- nzTheme="outline"
- class="icon-database"></i>
- Created at: {{ selectedVersionCreationTime }}
+ <div class="right-sider-scrolling-container">
+ <div class="right-sider">
Review Comment:
The overflow-y: auto has to be applied to a parent div of the right-sider for the right-sider to scroll. And I couldn't apply it to nz-sider, the original parent of right-sider, since it caused clipping of the sider-resize-handle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): file upload section border [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on PR #3906:
URL: https://github.com/apache/texera/pull/3906#issuecomment-3404481022
Thanks for the PR! It’s a bit hard to see what changed—the diff includes about 200 lines. Also, the demo video in the description isn’t showing. You could add a blank line before and after the link, it should be displayed properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): file upload section border [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on code in PR #3906:
URL: https://github.com/apache/texera/pull/3906#discussion_r2433997637
##########
frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/dataset-detail.component.html:
##########
@@ -206,206 +206,208 @@ <h3 class="file-title">
nzTheme="outline"></i>
</div>
</nz-resize-handle>
- <div class="right-sider">
- <nz-collapse nzGhost>
- <nz-collapse-panel
- nzHeader="Current Versions"
- nzActive="true">
- <div class="version-storage">
- <h6 style="font-weight: lighter; font-size: 0.9em">Choose a Version:</h6>
- <div class="select-and-button-container">
- <nz-select
- nzShowSearch
- nzAllowClear
- nzPlaceHolder="Select a version"
- (ngModelChange)="onVersionSelected($event)"
- [(ngModel)]="selectedVersion">
- <nz-option
- *ngFor="let version of versions"
- [nzValue]="version"
- [nzLabel]="version.name"></nz-option>
- </nz-select>
- <button
- nz-button
- nz-tooltip="Download Dataset"
- (click)="onClickDownloadVersionAsZip()"
- *ngIf="selectedVersion"
- [disabled]="!isLogin || !isDownloadAllowed()"
- class="spaced-button">
- <i
- nz-icon
- nzType="download"
- nzTheme="outline"></i>
- </button>
- </div>
- <ng-container *ngIf="selectedVersion">
- <div class="version-size">
- <i
- nz-icon
- nzType="database"
- nzTheme="outline"
- class="icon-database"></i>
- Version Size: {{ formatSize(currentDatasetVersionSize) }}
- </div>
- <div
- *ngIf="selectedVersionCreationTime"
- class="version-date">
- <i
- nz-icon
- nzType="calendar"
- nzTheme="outline"
- class="icon-database"></i>
- Created at: {{ selectedVersionCreationTime }}
+ <div class="right-sider-scrolling-container">
+ <div class="right-sider">
Review Comment:
I noticed that the "right-sider" currently has no styles. Could we avoid the extra wrapper "right-sider-scrolling-container" by applying the scrolling styles directly to the existing element?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org