[GitHub] StephanEwen commented on issue #6663: [FLINK-10209][build] Exclude jdk.tools dependency from hadoop

[GitBox <gi...@apache.org>]

StephanEwen commented on issue #6663:  [FLINK-10209][build] Exclude jdk.tools dependency from hadoop 
URL: https://github.com/apache/flink/pull/6663#issuecomment-420195374
 
 
   Thanks for the fix!
   
   I assume that it does not work to always exclude the dependency from Hadoop, in Java 8 as well?
   What error do we get in that case?
   
   Slightly off topic:
   
   Would it make sense to start moving `flink-hadoop-shaded` to the `flink-shaded` project? We could have simply the latest bugfix of each minor version. That would also allow us to properly analyze dependencies, shade them, get the dependency convergence in Flink under control, etc.
   
   In the long run, we want to encourage exporting the HADOOP_CLASSPATH anyways, rather than adding Hadoop to Flink. The shaded artifacts would be mainly a convenience thing, and we don't  have to match all vendor-specific versions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services