You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gary Helmling (JIRA)" <ji...@apache.org> on 2011/08/11 21:04:27 UTC
[jira] [Created] (HBASE-4193) Enhance RPC debug logging to provide
more details on call contents
Enhance RPC debug logging to provide more details on call contents
------------------------------------------------------------------
Key: HBASE-4193
URL: https://issues.apache.org/jira/browse/HBASE-4193
Project: HBase
Issue Type: Improvement
Components: ipc
Reporter: Gary Helmling
Priority: Minor
The current HBaseServer debug logging, while verbose, doesn't provide much information on the actual contents of RPC calls being handled. This makes it difficult to diagnose why some calls make take much longer to process that others. Have more information on the size of client calls, and the contents of those calls (especially in the case of batch or multi operations) would provide a lot more context for tracking down issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4193) Enhance RPC debug logging to provide
more details on call contents
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling resolved HBASE-4193.
----------------------------------
Resolution: Fixed
Committed to trunk. Thanks for the reviews!
> Enhance RPC debug logging to provide more details on call contents
> ------------------------------------------------------------------
>
> Key: HBASE-4193
> URL: https://issues.apache.org/jira/browse/HBASE-4193
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4193.patch, HBASE-4193_final.patch
>
>
> The current HBaseServer debug logging, while verbose, doesn't provide much information on the actual contents of RPC calls being handled. This makes it difficult to diagnose why some calls make take much longer to process that others. Have more information on the size of client calls, and the contents of those calls (especially in the case of batch or multi operations) would provide a lot more context for tracking down issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4193) Enhance RPC debug logging to
provide more details on call contents
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083527#comment-13083527 ]
Andrew Purtell commented on HBASE-4193:
---------------------------------------
+1
> Enhance RPC debug logging to provide more details on call contents
> ------------------------------------------------------------------
>
> Key: HBASE-4193
> URL: https://issues.apache.org/jira/browse/HBASE-4193
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4193.patch
>
>
> The current HBaseServer debug logging, while verbose, doesn't provide much information on the actual contents of RPC calls being handled. This makes it difficult to diagnose why some calls make take much longer to process that others. Have more information on the size of client calls, and the contents of those calls (especially in the case of batch or multi operations) would provide a lot more context for tracking down issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4193) Enhance RPC debug logging to provide
more details on call contents
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated HBASE-4193:
---------------------------------
Attachment: HBASE-4193.patch
This patch enhances the debug logging output of HBaseServer to include the raw size of the client request and some introspected details of the contents.
The enhanced logging will produce lines like:
{noformat}
2011-08-11 12:29:49,836 DEBUG [IPC Server handler 2 on 36501] ipc.WritableRpcEngine$Server(318): Call #540; Served: HRegionInterface#multi queueTime=0 processingTime=461 contents=139 values [ min=5 max=5 avg=5 ], 139 Puts, 139 KeyValues
2011-08-11 12:29:49,894 DEBUG [IPC Server handler 3 on 54615] ipc.WritableRpcEngine$Server(318): Call #537; Served: HRegionInterface#multi queueTime=0 processingTime=546 contents=219 values [ min=5 max=5 avg=5 ], 219 Puts, 219 KeyValues
{noformat}
There are 2 key changes from the current logging:
# include the call ID (for easier cross referencing with other log messages
# add the contents=... output with counts of objects in the request and simple stats on value sizes from KVs
In addition, the lines shown above have been moved to a separate logger (org.apache.hadoop.ipc.HBaseServer.trace), so that they can be enabled separately from other IPC debugging output. Unless explicitly enabled, they don't incur any additional overhead.
> Enhance RPC debug logging to provide more details on call contents
> ------------------------------------------------------------------
>
> Key: HBASE-4193
> URL: https://issues.apache.org/jira/browse/HBASE-4193
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Minor
> Attachments: HBASE-4193.patch
>
>
> The current HBaseServer debug logging, while verbose, doesn't provide much information on the actual contents of RPC calls being handled. This makes it difficult to diagnose why some calls make take much longer to process that others. Have more information on the size of client calls, and the contents of those calls (especially in the case of batch or multi operations) would provide a lot more context for tracking down issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4193) Enhance RPC debug logging to
provide more details on call contents
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083891#comment-13083891 ]
stack commented on HBASE-4193:
------------------------------
+1 Excellent!
Would imagine once enabled that it will be super expensive logging but then I like have you labelled TRACELOG so that sets up right expectation.
Add license on commit to Objects.java.
> Enhance RPC debug logging to provide more details on call contents
> ------------------------------------------------------------------
>
> Key: HBASE-4193
> URL: https://issues.apache.org/jira/browse/HBASE-4193
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4193.patch
>
>
> The current HBaseServer debug logging, while verbose, doesn't provide much information on the actual contents of RPC calls being handled. This makes it difficult to diagnose why some calls make take much longer to process that others. Have more information on the size of client calls, and the contents of those calls (especially in the case of batch or multi operations) would provide a lot more context for tracking down issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4193) Enhance RPC debug logging to provide
more details on call contents
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling reassigned HBASE-4193:
------------------------------------
Assignee: Gary Helmling
> Enhance RPC debug logging to provide more details on call contents
> ------------------------------------------------------------------
>
> Key: HBASE-4193
> URL: https://issues.apache.org/jira/browse/HBASE-4193
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Minor
>
> The current HBaseServer debug logging, while verbose, doesn't provide much information on the actual contents of RPC calls being handled. This makes it difficult to diagnose why some calls make take much longer to process that others. Have more information on the size of client calls, and the contents of those calls (especially in the case of batch or multi operations) would provide a lot more context for tracking down issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4193) Enhance RPC debug logging to provide
more details on call contents
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated HBASE-4193:
---------------------------------
Fix Version/s: 0.92.0
> Enhance RPC debug logging to provide more details on call contents
> ------------------------------------------------------------------
>
> Key: HBASE-4193
> URL: https://issues.apache.org/jira/browse/HBASE-4193
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4193.patch
>
>
> The current HBaseServer debug logging, while verbose, doesn't provide much information on the actual contents of RPC calls being handled. This makes it difficult to diagnose why some calls make take much longer to process that others. Have more information on the size of client calls, and the contents of those calls (especially in the case of batch or multi operations) would provide a lot more context for tracking down issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4193) Enhance RPC debug logging to provide
more details on call contents
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated HBASE-4193:
---------------------------------
Attachment: HBASE-4193_final.patch
Final patch committed to trunk.
> Enhance RPC debug logging to provide more details on call contents
> ------------------------------------------------------------------
>
> Key: HBASE-4193
> URL: https://issues.apache.org/jira/browse/HBASE-4193
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4193.patch, HBASE-4193_final.patch
>
>
> The current HBaseServer debug logging, while verbose, doesn't provide much information on the actual contents of RPC calls being handled. This makes it difficult to diagnose why some calls make take much longer to process that others. Have more information on the size of client calls, and the contents of those calls (especially in the case of batch or multi operations) would provide a lot more context for tracking down issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4193) Enhance RPC debug logging to
provide more details on call contents
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083982#comment-13083982 ]
Hudson commented on HBASE-4193:
-------------------------------
Integrated in HBase-TRUNK #2111 (See [https://builds.apache.org/job/HBase-TRUNK/2111/])
HBASE-4193 Enhance RPC debug logging with details on call contents
garyh :
Files :
* /hbase/trunk/conf/log4j.properties
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/Objects.java
> Enhance RPC debug logging to provide more details on call contents
> ------------------------------------------------------------------
>
> Key: HBASE-4193
> URL: https://issues.apache.org/jira/browse/HBASE-4193
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4193.patch, HBASE-4193_final.patch
>
>
> The current HBaseServer debug logging, while verbose, doesn't provide much information on the actual contents of RPC calls being handled. This makes it difficult to diagnose why some calls make take much longer to process that others. Have more information on the size of client calls, and the contents of those calls (especially in the case of batch or multi operations) would provide a lot more context for tracking down issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira