You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/05/16 05:25:36 UTC

[GitHub] [bookkeeper] karanmehta93 commented on issue #2094: (WIP) Have min time interval for force compaction

karanmehta93 commented on issue #2094: (WIP) Have min time interval for force compaction
URL: https://github.com/apache/bookkeeper/pull/2094#issuecomment-492921715
 
 
   As discussed with @reddycharan offline, due to certain race conditions, it might be simply preferable to update `lastCompactionTime` for every GC run, irrespective of who the caller is (forceGC run by `LedgerDirsMonitor` or scheduled GC Thread run). 
   
   Without this PR, when disks get full, it will try running force GC every 10 seconds (since the monitor thread runs every 10 seconds), causing lot of burden on system. With this pause introduced by the PR, we would ensure some wait between consecutive GC runs. I also propose to remove the config parameter `FORCE_COMPACTION_INTERVAL` and fix it to `getGcWaitTime() / 2`, which is the current default.
   
   Thoughts? @sijie @jvrao 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services