You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/23 13:45:23 UTC

[GitHub] [spark] LuciferYang commented on a change in pull request #35937: [SPARK-38623][SQL] Simplify the compatibility check in HashShuffleSpec

LuciferYang commented on a change in pull request #35937:
URL: https://github.com/apache/spark/pull/35937#discussion_r833285367



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
##########
@@ -94,17 +94,25 @@ case class ClusteredDistribution(
     HashPartitioning(clustering, numPartitions)
   }
 
+  lazy val distKeyToPos = {

Review comment:
       should we declare the type for public val
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org