You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/11 14:16:02 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #9283:
[api] Fix, related fields need to be explicitly defined
dpgaspar opened a new pull request #9283: [api] Fix, related fields need to be explicitly defined
URL: https://github.com/apache/incubator-superset/pull/9283
### CATEGORY
- [ ] Bug Fix
- [X] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
No problem found. But it's better to play safe and by default lock down the generic related endpoint. So, now we need to explicitly define the related fields we want to expose
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #9283: [api] Fix,
related fields need to be explicitly defined
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #9283: [api] Fix, related fields need to be explicitly defined
URL: https://github.com/apache/incubator-superset/pull/9283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request
#9283: [api] Fix, related fields need to be explicitly defined
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #9283: [api] Fix, related fields need to be explicitly defined
URL: https://github.com/apache/incubator-superset/pull/9283#discussion_r391320777
##########
File path: superset/datasets/api.py
##########
@@ -98,6 +98,7 @@ class DatasetRestApi(BaseSupersetModelRestApi):
filter_rel_fields_field = {"owners": "first_name", "database": "database_name"}
filter_rel_fields = {"database": [["id", DatabaseFilter, lambda: []]]}
+ allowed_rel_fields = {"database"}
Review comment:
```suggestion
allowed_rel_fields = {"database", "owners"}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org