You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jiakai-li (via GitHub)" <gi...@apache.org> on 2024/12/06 20:17:41 UTC
[PR] Add `_missing_` to make `FileFormat` case insensitive [iceberg-python]
jiakai-li opened a new pull request, #1411:
URL: https://github.com/apache/iceberg-python/pull/1411
**This pull request makes the following changes:**
* Fixes issue #1362 *
The change is to make `FileFormat` case insensitve. The idea is to add `_missing_` funtion to handle lower case in a pythonic way.
Also included corresponding test at `tests/test_manifest.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add `_missing_` to make `FileFormat` case insensitive [iceberg-python]
Posted by "jiakai-li (via GitHub)" <gi...@apache.org>.
jiakai-li commented on PR #1411:
URL: https://github.com/apache/iceberg-python/pull/1411#issuecomment-2524090648
Hey @kevinjqliu @Fokko, this PR is ready for review. Rather than modifying the `__new__` method, I think it's probably a better option to modify `_missing_` based on its semantic meaning. Please let me know if there is more change you would like me to make. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add `_missing_` to make `FileFormat` case insensitive [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #1411:
URL: https://github.com/apache/iceberg-python/pull/1411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org