[GitHub] [airflow] potiuk commented on pull request #13714: Add open id dependency

[GitBox <gi...@apache.org>]

potiuk commented on pull request #13714:
URL: https://github.com/apache/airflow/pull/13714#issuecomment-761627603


   I am also on the fence but we already have three issues raised by poetry users. and we can expect more issues if it continues to fail build. The aim is not to fix poetry installation, but at least give the poetry users clear indication of dependency problems. Right now they have a compilation error that is rather misleading so no wonder they open issue for it.
   
   According to https://github.com/apache/airflow/issues/13149#issuecomment-748705193  it works when added as direct dependency for poetry, so i believe it should work when we add it to install requires directly rather than transitive dependency of FAB, and this is the version that is currently installed when pip installs it. 
   
   I'd say no harm with adding it just to prevent people from opening new issues about it. We are not fixing poetry installation with that one. It will likely not work still.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org