You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/17 06:50:50 UTC

[GitHub] [pulsar] tisonkun commented on a diff in pull request #17077: [Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata

tisonkun commented on code in PR #17077:
URL: https://github.com/apache/pulsar/pull/17077#discussion_r947514100


##########
pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java:
##########
@@ -434,10 +438,13 @@ public void close() {
         }
     }
 
-
-    private void startBookieWithRocksDB() throws Exception {
-        log.info("Starting BK with RocksDb metadata store");
-        String metadataStoreUrl = "rocksdb://" + Paths.get(metadataDir).toAbsolutePath();
+    private void startBookieWithMetadataStore() throws Exception {
+        if(StringUtils.isBlank(metadataStoreUrl)){
+            log.info("Starting BK with RocksDb metadata store");
+            metadataStoreUrl = "rocksdb://" + Paths.get(metadataDir).toAbsolutePath();
+        }else{
+            log.info("Starting BK with metadata store:",metadataStoreUrl);
+        }

Review Comment:
   Please format this code block according to our code style settings. Briefly, add necessary blanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org