You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/10/21 11:10:29 UTC
[GitHub] [inlong] bluewang opened a new pull request, #6260: [INLONG-6258][Dashboard] Source data delimiter changed from ASCII to symbol
bluewang opened a new pull request, #6260:
URL: https://github.com/apache/inlong/pull/6260
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes https://github.com/apache/inlong/issues/6258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on pull request #6260: [INLONG-6258][Dashboard] Source data delimiter changed from ASCII to symbol
Posted by GitBox <gi...@apache.org>.
healchow commented on PR #6260:
URL: https://github.com/apache/inlong/pull/6260#issuecomment-1289916898
Keep the usage of ASCII for data separators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6260: [INLONG-6258][Dashboard] Source data delimiter changed from ASCII to symbol
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6260:
URL: https://github.com/apache/inlong/pull/6260#discussion_r1003946795
##########
inlong-dashboard/src/metas/stream/index.tsx:
##########
@@ -142,27 +142,27 @@ const fieldsDefault: FieldItemType[] = [
options: [
{
label: i18n.t('meta.Stream.DataSeparator.Space'),
- value: '32',
+ value: ' ',
Review Comment:
Spaces are not easy to identify after being saved in the back-end database;
In addition, if the user needs to set a special character, there may be problems with the front-end display and back-end storage.
Therefore, it is recommended to use ASCII code to save.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6260: [INLONG-6258][Dashboard] Source data delimiter changed from ASCII to symbol
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6260:
URL: https://github.com/apache/inlong/pull/6260#discussion_r1002487044
##########
inlong-dashboard/src/metas/stream/index.tsx:
##########
@@ -142,27 +142,27 @@ const fieldsDefault: FieldItemType[] = [
options: [
{
label: i18n.t('meta.Stream.DataSeparator.Space'),
- value: '32',
+ value: '(Space)',
Review Comment:
Did this `Space` is OK? The backend service might not recognize it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow closed pull request #6260: [INLONG-6258][Dashboard] Source data delimiter changed from ASCII to symbol
Posted by GitBox <gi...@apache.org>.
healchow closed pull request #6260: [INLONG-6258][Dashboard] Source data delimiter changed from ASCII to symbol
URL: https://github.com/apache/inlong/pull/6260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org