You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/10/17 08:02:13 UTC

[GitHub] [servicecomb-service-center] popozy opened a new pull request #718: [SCB 2094] implement ms module interface (#710)

popozy opened a new pull request #718:
URL: https://github.com/apache/servicecomb-service-center/pull/718


   ### Commit message
   1. implement service/ms/etcd interface
       + GetSchema
       + GetAllSchema
       + DeleteSchema
       + AddRule
       + GetRule
       + DeleteRule
       + UpdateRule
   
   2. finish unit test relative to the instance above
   
   3. add datasource to unit shell script to make github ci make sense to it
   
   ### History pr
   #710 -- implement ms module interface
   #708 -- optimize service/util func invoker in ms/etcd package
   #703  -- service/ms interface implement
   #701 -- service/ms interface implement
   #698 -- service/ms interface implement
   #697 -- background of the enhancement, service/ms interface implement
   #695 -- framework of the enhancement
   
   ### Changes note
   | Module | Lines |
   |--------| ------|
   | Unit test| 900 |
   | Schema & Rule implement logic| 600 |


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] popozy commented on pull request #718: [SCB 2094] implement ms module interface

Posted by GitBox <gi...@apache.org>.
popozy commented on pull request #718:
URL: https://github.com/apache/servicecomb-service-center/pull/718#issuecomment-710770455


   please make this pr merged before any other pr which modify datasouce module, because datasouce module ut will make sense in github ci by this pr modifying the scripts/ut_test_in_docker.sh:
   ``` sh
   [ $? == 0 ] && ut_for_dir datasource
   ```
   
   @little-cui @tianxiaoliang PTAL


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] popozy edited a comment on pull request #718: [SCB 2094] implement ms module interface

Posted by GitBox <gi...@apache.org>.
popozy edited a comment on pull request #718:
URL: https://github.com/apache/servicecomb-service-center/pull/718#issuecomment-710770455


   please make this pr merged before any other pr which modify datasouce module, because datasouce module ut will make sense in github ci by this pr modifying the scripts/ut_test_in_docker.sh:
   ``` sh
   [ $? == 0 ] && ut_for_dir datasource
   ```
   
   @robotLJW please check why addTag test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] popozy closed pull request #718: [SCB 2094] implement ms module interface

Posted by GitBox <gi...@apache.org>.
popozy closed pull request #718:
URL: https://github.com/apache/servicecomb-service-center/pull/718


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #718: [SCB 2094] implement ms module interface

Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #718:
URL: https://github.com/apache/servicecomb-service-center/pull/718


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] popozy commented on pull request #718: [SCB 2094] implement ms module interface

Posted by GitBox <gi...@apache.org>.
popozy commented on pull request #718:
URL: https://github.com/apache/servicecomb-service-center/pull/718#issuecomment-710787648


   LGTM @little-cui @tianxiaoliang PTAL


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org