[GitHub] [couchdb-fauxton] popojargo commented on a change in pull request #1227: Add Search support

[GitBox <gi...@apache.org>]

popojargo commented on a change in pull request #1227: Add Search support
URL: https://github.com/apache/couchdb-fauxton/pull/1227#discussion_r328113991
 
 

 ##########
 File path: app/addons/search/components/Analyzer.js
 ##########
 @@ -0,0 +1,143 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+import PropTypes from 'prop-types';
+import React from 'react';
+import Constants from '../constants';
+import AnalyzerMultiple from './AnalyzerMultiple';
+import AnalyzerDropdown from './AnalyzerDropdown';
+
+// handles the entire Analyzer section: Simple and Multiple analyzers
+export default class Analyzer extends React.Component {
+  static propTypes = {
+    analyzerType: PropTypes.string.isRequired,
+    analyzerFields: PropTypes.array.isRequired,
+    defaultMultipleAnalyzer: PropTypes.string.isRequired,
+    singleAnalyzer: PropTypes.string.isRequired,
+    setAnalyzerType: PropTypes.func.isRequired,
+    setSingleAnalyzer: PropTypes.func.isRequired,
+    setDefaultMultipleAnalyzer: PropTypes.func.isRequired,
+    addAnalyzerRow: PropTypes.func.isRequired
+  };
+
+  constructor(props) {
+    super(props);
+    this.selectAnalyzerType = this.selectAnalyzerType.bind(this);
 
 Review comment:
   Why binding to this when using arrow functions?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services