You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Puneet Gupta <pu...@gmail.com> on 2016/01/27 12:29:33 UTC
Review Request 42850: LENS-909
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-909
https://issues.apache.org/jira/browse/LENS-909
Repository: lens
Description
-------
We should avoid sending email notification with inmemory results
**Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921)**
Changes wrt to lens-921 are done in following files only
* lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
* lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9af
lens-server/src/main/resources/lensserver-default.xml cac641a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5
src/site/apt/admin/config.apt 54f827e
src/site/apt/admin/session-config.apt 05a2c2c
Diff: https://reviews.apache.org/r/42850/diff/
Testing
-------
[INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
[INFO] Lens .............................................. SUCCESS [3.340s]
[INFO] Lens API .......................................... SUCCESS [20.204s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
[INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
[INFO] Lens DB storage ................................... SUCCESS [15.304s]
[INFO] Lens Query Library ................................ SUCCESS [12.357s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
[INFO] Lens Server ....................................... SUCCESS [8:58.139s]
[INFO] Lens client ....................................... SUCCESS [30.351s]
[INFO] Lens CLI .......................................... SUCCESS [45.652s]
[INFO] Lens Examples ..................................... SUCCESS [6.089s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
[INFO] Lens Distribution ................................. SUCCESS [7.953s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
[INFO] Lens Regression ................................... SUCCESS [10.147s]
[INFO] Lens UI ........................................... SUCCESS [28.590s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:27.663s
[INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
[INFO] Final Memory: 154M/2035M
[INFO] ------------------------------------------------------------------------
**Email Message looks like this**
(org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
by localhost
with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
Mon, 25 Jan 2016 21:05:25 +0530 (IST)
Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
From: blah@company.com
To: foo@localhost
Cc: foo1@localhost
Cc: foo2@localhost
Cc: foo3@localhost
Message-ID: <12...@IM1995-X0>
Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="----=_Part_0_748061076.1453736125428"
------=_Part_0_748061076.1453736125428
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
*Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
------=_Part_0_748061076.1453736125428--
Thanks,
Puneet Gupta
Re: Review Request 42850: LENS-909
Posted by Puneet Gupta <pu...@gmail.com>.
> On Jan. 27, 2016, 11:34 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java, line 81
> > <https://reviews.apache.org/r/42850/diff/1/?file=1222636#file1222636line81>
> >
> > Thinking of changing the message to :
> >
> > A. Query Result is cached in the server temporarily and is accessible until <time>
> >
> > or
> >
> > B. Query result is available in the sever and will be accessible until <time>
> >
> > +1 for A
<p>Correction :</p>
<p>Query Result is temporarily cached in the server and will be available until <time></p>
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/#review116573
-----------------------------------------------------------
On Jan. 27, 2016, 11:29 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42850/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 11:29 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-909
> https://issues.apache.org/jira/browse/LENS-909
>
>
> Repository: lens
>
>
> Description
> -------
>
> We should avoid sending email notification with inmemory results
>
> **Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921)**
> Changes wrt to lens-921 are done in following files only
> * lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
> * lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9af
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5
> src/site/apt/admin/config.apt 54f827e
> src/site/apt/admin/session-config.apt 05a2c2c
>
> Diff: https://reviews.apache.org/r/42850/diff/
>
>
> Testing
> -------
>
> [INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
> [INFO] Lens .............................................. SUCCESS [3.340s]
> [INFO] Lens API .......................................... SUCCESS [20.204s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
> [INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
> [INFO] Lens DB storage ................................... SUCCESS [15.304s]
> [INFO] Lens Query Library ................................ SUCCESS [12.357s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
> [INFO] Lens Server ....................................... SUCCESS [8:58.139s]
> [INFO] Lens client ....................................... SUCCESS [30.351s]
> [INFO] Lens CLI .......................................... SUCCESS [45.652s]
> [INFO] Lens Examples ..................................... SUCCESS [6.089s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
> [INFO] Lens Distribution ................................. SUCCESS [7.953s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
> [INFO] Lens Regression ................................... SUCCESS [10.147s]
> [INFO] Lens UI ........................................... SUCCESS [28.590s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:27.663s
> [INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
> [INFO] Final Memory: 154M/2035M
> [INFO] ------------------------------------------------------------------------
>
>
> **Email Message looks like this**
> (org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
> by localhost
> with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
> Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> From: blah@company.com
> To: foo@localhost
> Cc: foo1@localhost
> Cc: foo2@localhost
> Cc: foo3@localhost
> Message-ID: <12...@IM1995-X0>
> Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
> MIME-Version: 1.0
> Content-Type: multipart/mixed;
> boundary="----=_Part_0_748061076.1453736125428"
>
> ------=_Part_0_748061076.1453736125428
> Content-Type: text/plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
>
> *Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
> ------=_Part_0_748061076.1453736125428--
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 42850: LENS-909
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/#review116573
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java (line 81)
<https://reviews.apache.org/r/42850/#comment177599>
Thinking of changing the message to :
A. Query Result is cached in the server temporarily and is accessible until <time>
or
B. Query result is available in the sever and will be accessible until <time>
+1 for A
- Puneet Gupta
On Jan. 27, 2016, 11:29 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42850/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 11:29 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-909
> https://issues.apache.org/jira/browse/LENS-909
>
>
> Repository: lens
>
>
> Description
> -------
>
> We should avoid sending email notification with inmemory results
>
> **Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921)**
> Changes wrt to lens-921 are done in following files only
> * lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
> * lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2dff9af
> lens-server/src/main/resources/lensserver-default.xml cac641a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 494bce5
> src/site/apt/admin/config.apt 54f827e
> src/site/apt/admin/session-config.apt 05a2c2c
>
> Diff: https://reviews.apache.org/r/42850/diff/
>
>
> Testing
> -------
>
> [INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
> [INFO] Lens .............................................. SUCCESS [3.340s]
> [INFO] Lens API .......................................... SUCCESS [20.204s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
> [INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
> [INFO] Lens DB storage ................................... SUCCESS [15.304s]
> [INFO] Lens Query Library ................................ SUCCESS [12.357s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
> [INFO] Lens Server ....................................... SUCCESS [8:58.139s]
> [INFO] Lens client ....................................... SUCCESS [30.351s]
> [INFO] Lens CLI .......................................... SUCCESS [45.652s]
> [INFO] Lens Examples ..................................... SUCCESS [6.089s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
> [INFO] Lens Distribution ................................. SUCCESS [7.953s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
> [INFO] Lens Regression ................................... SUCCESS [10.147s]
> [INFO] Lens UI ........................................... SUCCESS [28.590s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:27.663s
> [INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
> [INFO] Final Memory: 154M/2035M
> [INFO] ------------------------------------------------------------------------
>
>
> **Email Message looks like this**
> (org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
> by localhost
> with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
> Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> From: blah@company.com
> To: foo@localhost
> Cc: foo1@localhost
> Cc: foo2@localhost
> Cc: foo3@localhost
> Message-ID: <12...@IM1995-X0>
> Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
> MIME-Version: 1.0
> Content-Type: multipart/mixed;
> boundary="----=_Part_0_748061076.1453736125428"
>
> ------=_Part_0_748061076.1453736125428
> Content-Type: text/plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
>
> *Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
> ------=_Part_0_748061076.1453736125428--
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 42850: Lens 909 - avoid sending email notification
with inmemory results
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/#review118001
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Feb. 5, 2016, 10:01 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42850/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 10:01 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-909
> https://issues.apache.org/jira/browse/LENS-909
>
>
> Repository: lens
>
>
> Description
> -------
>
> We should avoid sending email notification with inmemory results
>
> ** Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921) **
> Changes wrt to lens-921 are done in following files only
> - lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
> - lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java e97a5a3
>
> Diff: https://reviews.apache.org/r/42850/diff/
>
>
> Testing
> -------
>
> [INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
> [INFO] Lens .............................................. SUCCESS [3.340s]
> [INFO] Lens API .......................................... SUCCESS [20.204s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
> [INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
> [INFO] Lens DB storage ................................... SUCCESS [15.304s]
> [INFO] Lens Query Library ................................ SUCCESS [12.357s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
> [INFO] Lens Server ....................................... SUCCESS [8:58.139s]
> [INFO] Lens client ....................................... SUCCESS [30.351s]
> [INFO] Lens CLI .......................................... SUCCESS [45.652s]
> [INFO] Lens Examples ..................................... SUCCESS [6.089s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
> [INFO] Lens Distribution ................................. SUCCESS [7.953s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
> [INFO] Lens Regression ................................... SUCCESS [10.147s]
> [INFO] Lens UI ........................................... SUCCESS [28.590s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:27.663s
> [INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
> [INFO] Final Memory: 154M/2035M
> [INFO] ------------------------------------------------------------------------
>
>
> **Email Message looks like this**
> (org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
> by localhost
> with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
> Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> From: blah@company.com
> To: foo@localhost
> Cc: foo1@localhost
> Cc: foo2@localhost
> Cc: foo3@localhost
> Message-ID: <12...@IM1995-X0>
> Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
> MIME-Version: 1.0
> Content-Type: multipart/mixed;
> boundary="----=_Part_0_748061076.1453736125428"
>
> ------=_Part_0_748061076.1453736125428
> Content-Type: text/plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
>
> *Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
> ------=_Part_0_748061076.1453736125428--
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 42850: Lens 909 - avoid sending email notification
with inmemory results
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 10:01 a.m.)
Review request for lens.
Changes
-------
Fixed missed comment "read from conf passed instead of static conf."
Bugs: LENS-909
https://issues.apache.org/jira/browse/LENS-909
Repository: lens
Description
-------
We should avoid sending email notification with inmemory results
** Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921) **
Changes wrt to lens-921 are done in following files only
- lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
- lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java e97a5a3
Diff: https://reviews.apache.org/r/42850/diff/
Testing
-------
[INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
[INFO] Lens .............................................. SUCCESS [3.340s]
[INFO] Lens API .......................................... SUCCESS [20.204s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
[INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
[INFO] Lens DB storage ................................... SUCCESS [15.304s]
[INFO] Lens Query Library ................................ SUCCESS [12.357s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
[INFO] Lens Server ....................................... SUCCESS [8:58.139s]
[INFO] Lens client ....................................... SUCCESS [30.351s]
[INFO] Lens CLI .......................................... SUCCESS [45.652s]
[INFO] Lens Examples ..................................... SUCCESS [6.089s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
[INFO] Lens Distribution ................................. SUCCESS [7.953s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
[INFO] Lens Regression ................................... SUCCESS [10.147s]
[INFO] Lens UI ........................................... SUCCESS [28.590s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:27.663s
[INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
[INFO] Final Memory: 154M/2035M
[INFO] ------------------------------------------------------------------------
**Email Message looks like this**
(org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
by localhost
with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
Mon, 25 Jan 2016 21:05:25 +0530 (IST)
Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
From: blah@company.com
To: foo@localhost
Cc: foo1@localhost
Cc: foo2@localhost
Cc: foo3@localhost
Message-ID: <12...@IM1995-X0>
Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="----=_Part_0_748061076.1453736125428"
------=_Part_0_748061076.1453736125428
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
*Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
------=_Part_0_748061076.1453736125428--
Thanks,
Puneet Gupta
Re: Review Request 42850: Lens 909 - avoid sending email notification
with inmemory results
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 3:09 a.m.)
Review request for lens.
Changes
-------
** Upadted diff after merging with master
Bugs: LENS-909
https://issues.apache.org/jira/browse/LENS-909
Repository: lens
Description
-------
We should avoid sending email notification with inmemory results
** Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921) **
Changes wrt to lens-921 are done in following files only
- lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
- lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java e97a5a3
Diff: https://reviews.apache.org/r/42850/diff/
Testing
-------
[INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
[INFO] Lens .............................................. SUCCESS [3.340s]
[INFO] Lens API .......................................... SUCCESS [20.204s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
[INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
[INFO] Lens DB storage ................................... SUCCESS [15.304s]
[INFO] Lens Query Library ................................ SUCCESS [12.357s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
[INFO] Lens Server ....................................... SUCCESS [8:58.139s]
[INFO] Lens client ....................................... SUCCESS [30.351s]
[INFO] Lens CLI .......................................... SUCCESS [45.652s]
[INFO] Lens Examples ..................................... SUCCESS [6.089s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
[INFO] Lens Distribution ................................. SUCCESS [7.953s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
[INFO] Lens Regression ................................... SUCCESS [10.147s]
[INFO] Lens UI ........................................... SUCCESS [28.590s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:27.663s
[INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
[INFO] Final Memory: 154M/2035M
[INFO] ------------------------------------------------------------------------
**Email Message looks like this**
(org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
by localhost
with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
Mon, 25 Jan 2016 21:05:25 +0530 (IST)
Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
From: blah@company.com
To: foo@localhost
Cc: foo1@localhost
Cc: foo2@localhost
Cc: foo3@localhost
Message-ID: <12...@IM1995-X0>
Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="----=_Part_0_748061076.1453736125428"
------=_Part_0_748061076.1453736125428
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
*Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
------=_Part_0_748061076.1453736125428--
Thanks,
Puneet Gupta
Re: Review Request 42850: Lens 909 - avoid sending email notification
with inmemory results
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 2:07 a.m.)
Review request for lens.
Changes
-------
- Fixed review comments
- Updated test case to check for time
- Merged code with Lens-901 (streaming support). It was required for test case
- Review only two files ( Rest should be part of lens-901)
-- lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
-- lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
- Once Lens-901 is commited, will create a diff again
** Email message = "Query result is temporarily cached in the server and will be available until 2016-02-04 08:11:25 PM, IST" **
** Was able to build and run test cases **
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.326s]
[INFO] Lens .............................................. SUCCESS [3.961s]
[INFO] Lens API .......................................... SUCCESS [26.918s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.617s]
[INFO] Lens Cube ......................................... SUCCESS [11:24.332s]
[INFO] Lens DB storage ................................... SUCCESS [19.429s]
[INFO] Lens Query Library ................................ SUCCESS [16.077s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.114s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.923s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [16.692s]
[INFO] Lens Server ....................................... SUCCESS [16:27.333s]
[INFO] Lens client ....................................... SUCCESS [37.889s]
[INFO] Lens CLI .......................................... SUCCESS [52.137s]
[INFO] Lens Examples ..................................... SUCCESS [8.872s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.727s]
[INFO] Lens Distribution ................................. SUCCESS [10.172s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.988s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.863s]
[INFO] Lens Regression ................................... SUCCESS [13.848s]
[INFO] Lens UI ........................................... SUCCESS [29.865s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 37:04.228s
[INFO] Finished at: Thu Feb 04
Bugs: LENS-909
https://issues.apache.org/jira/browse/LENS-909
Repository: lens
Description
-------
We should avoid sending email notification with inmemory results
** Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921) **
Changes wrt to lens-921 are done in following files only
- lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
- lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/QueryHandleWithResultSet.java a5da867
lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 915dac7
lens-driver-es/src/main/java/org/apache/lens/driver/es/client/ESResultSet.java 464b535
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 149c6ab
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java f8abd78
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 82d7513
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 8b4da3f
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java b96cf88
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 8df389b
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java ed1fc43
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java 0d64471
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PartiallyFetchedInMemoryResultSet.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 1269e45
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java a20cf47
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java e61398b
lens-server/src/main/resources/lenssession-default.xml a321c3f
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 4597f9d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java e97a5a3
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java d9b7679
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 6db990e
src/site/apt/admin/session-config.apt e108a13
Diff: https://reviews.apache.org/r/42850/diff/
Testing
-------
[INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
[INFO] Lens .............................................. SUCCESS [3.340s]
[INFO] Lens API .......................................... SUCCESS [20.204s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
[INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
[INFO] Lens DB storage ................................... SUCCESS [15.304s]
[INFO] Lens Query Library ................................ SUCCESS [12.357s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
[INFO] Lens Server ....................................... SUCCESS [8:58.139s]
[INFO] Lens client ....................................... SUCCESS [30.351s]
[INFO] Lens CLI .......................................... SUCCESS [45.652s]
[INFO] Lens Examples ..................................... SUCCESS [6.089s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
[INFO] Lens Distribution ................................. SUCCESS [7.953s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
[INFO] Lens Regression ................................... SUCCESS [10.147s]
[INFO] Lens UI ........................................... SUCCESS [28.590s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:27.663s
[INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
[INFO] Final Memory: 154M/2035M
[INFO] ------------------------------------------------------------------------
**Email Message looks like this**
(org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
by localhost
with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
Mon, 25 Jan 2016 21:05:25 +0530 (IST)
Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
From: blah@company.com
To: foo@localhost
Cc: foo1@localhost
Cc: foo2@localhost
Cc: foo3@localhost
Message-ID: <12...@IM1995-X0>
Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="----=_Part_0_748061076.1453736125428"
------=_Part_0_748061076.1453736125428
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
*Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
------=_Part_0_748061076.1453736125428--
Thanks,
Puneet Gupta
Re: Review Request 42850: Lens 909 - avoid sending email notification
with inmemory results
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 5:56 a.m.)
Review request for lens.
Changes
-------
Fixed Checkstyle
Bugs: LENS-909
https://issues.apache.org/jira/browse/LENS-909
Repository: lens
Description
-------
We should avoid sending email notification with inmemory results
** Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921) **
Changes wrt to lens-921 are done in following files only
- lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
- lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
Diff: https://reviews.apache.org/r/42850/diff/
Testing
-------
[INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
[INFO] Lens .............................................. SUCCESS [3.340s]
[INFO] Lens API .......................................... SUCCESS [20.204s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
[INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
[INFO] Lens DB storage ................................... SUCCESS [15.304s]
[INFO] Lens Query Library ................................ SUCCESS [12.357s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
[INFO] Lens Server ....................................... SUCCESS [8:58.139s]
[INFO] Lens client ....................................... SUCCESS [30.351s]
[INFO] Lens CLI .......................................... SUCCESS [45.652s]
[INFO] Lens Examples ..................................... SUCCESS [6.089s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
[INFO] Lens Distribution ................................. SUCCESS [7.953s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
[INFO] Lens Regression ................................... SUCCESS [10.147s]
[INFO] Lens UI ........................................... SUCCESS [28.590s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:27.663s
[INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
[INFO] Final Memory: 154M/2035M
[INFO] ------------------------------------------------------------------------
**Email Message looks like this**
(org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
by localhost
with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
Mon, 25 Jan 2016 21:05:25 +0530 (IST)
Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
From: blah@company.com
To: foo@localhost
Cc: foo1@localhost
Cc: foo2@localhost
Cc: foo3@localhost
Message-ID: <12...@IM1995-X0>
Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="----=_Part_0_748061076.1453736125428"
------=_Part_0_748061076.1453736125428
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
*Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
------=_Part_0_748061076.1453736125428--
Thanks,
Puneet Gupta
Re: Review Request 42850: Lens 909 - avoid sending email notification
with inmemory results
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 5:46 a.m.)
Review request for lens.
Changes
-------
Fixed review comment
Bugs: LENS-909
https://issues.apache.org/jira/browse/LENS-909
Repository: lens
Description
-------
We should avoid sending email notification with inmemory results
** Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921) **
Changes wrt to lens-921 are done in following files only
- lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
- lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
Diff: https://reviews.apache.org/r/42850/diff/
Testing
-------
[INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
[INFO] Lens .............................................. SUCCESS [3.340s]
[INFO] Lens API .......................................... SUCCESS [20.204s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
[INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
[INFO] Lens DB storage ................................... SUCCESS [15.304s]
[INFO] Lens Query Library ................................ SUCCESS [12.357s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
[INFO] Lens Server ....................................... SUCCESS [8:58.139s]
[INFO] Lens client ....................................... SUCCESS [30.351s]
[INFO] Lens CLI .......................................... SUCCESS [45.652s]
[INFO] Lens Examples ..................................... SUCCESS [6.089s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
[INFO] Lens Distribution ................................. SUCCESS [7.953s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
[INFO] Lens Regression ................................... SUCCESS [10.147s]
[INFO] Lens UI ........................................... SUCCESS [28.590s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:27.663s
[INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
[INFO] Final Memory: 154M/2035M
[INFO] ------------------------------------------------------------------------
**Email Message looks like this**
(org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
by localhost
with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
Mon, 25 Jan 2016 21:05:25 +0530 (IST)
Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
From: blah@company.com
To: foo@localhost
Cc: foo1@localhost
Cc: foo2@localhost
Cc: foo3@localhost
Message-ID: <12...@IM1995-X0>
Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="----=_Part_0_748061076.1453736125428"
------=_Part_0_748061076.1453736125428
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
*Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
------=_Part_0_748061076.1453736125428--
Thanks,
Puneet Gupta
Re: Review Request 42850: Lens 909 - avoid sending email notification
with inmemory results
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Feb. 1, 2016, 1:46 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java, line 198
> > <https://reviews.apache.org/r/42850/diff/3/?file=1227613#file1227613line198>
> >
> > Can we update test to check for time?
>
> Puneet Gupta wrote:
> TTL is in someway already checked by test case org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult(). This message just prints the TTL time. Do we need to test the time here again ?
>
> The current test case is updated to check for Message "Query result is temporarily cached in the server and will be available until"
Asked for test here, as the new code getting added here is not getting tested. For ex : date formatting. And the time is part of the message. I'm thinking it should be easy to update existing test for the same.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/#review117209
-----------------------------------------------------------
On Feb. 2, 2016, 5:56 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42850/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 5:56 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-909
> https://issues.apache.org/jira/browse/LENS-909
>
>
> Repository: lens
>
>
> Description
> -------
>
> We should avoid sending email notification with inmemory results
>
> ** Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921) **
> Changes wrt to lens-921 are done in following files only
> - lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
> - lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
>
> Diff: https://reviews.apache.org/r/42850/diff/
>
>
> Testing
> -------
>
> [INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
> [INFO] Lens .............................................. SUCCESS [3.340s]
> [INFO] Lens API .......................................... SUCCESS [20.204s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
> [INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
> [INFO] Lens DB storage ................................... SUCCESS [15.304s]
> [INFO] Lens Query Library ................................ SUCCESS [12.357s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
> [INFO] Lens Server ....................................... SUCCESS [8:58.139s]
> [INFO] Lens client ....................................... SUCCESS [30.351s]
> [INFO] Lens CLI .......................................... SUCCESS [45.652s]
> [INFO] Lens Examples ..................................... SUCCESS [6.089s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
> [INFO] Lens Distribution ................................. SUCCESS [7.953s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
> [INFO] Lens Regression ................................... SUCCESS [10.147s]
> [INFO] Lens UI ........................................... SUCCESS [28.590s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:27.663s
> [INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
> [INFO] Final Memory: 154M/2035M
> [INFO] ------------------------------------------------------------------------
>
>
> **Email Message looks like this**
> (org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
> by localhost
> with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
> Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> From: blah@company.com
> To: foo@localhost
> Cc: foo1@localhost
> Cc: foo2@localhost
> Cc: foo3@localhost
> Message-ID: <12...@IM1995-X0>
> Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
> MIME-Version: 1.0
> Content-Type: multipart/mixed;
> boundary="----=_Part_0_748061076.1453736125428"
>
> ------=_Part_0_748061076.1453736125428
> Content-Type: text/plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
>
> *Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
> ------=_Part_0_748061076.1453736125428--
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 42850: Lens 909 - avoid sending email notification
with inmemory results
Posted by Puneet Gupta <pu...@gmail.com>.
> On Feb. 1, 2016, 1:46 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java, line 198
> > <https://reviews.apache.org/r/42850/diff/3/?file=1227613#file1227613line198>
> >
> > Can we update test to check for time?
TTL is in someway already checked by test case org.apache.lens.server.query.TestQueryService.testTTLForInMemoryResult(). This message just prints the TTL time. Do we need to test the time here again ?
The current test case is updated to check for Message "Query result is temporarily cached in the server and will be available until"
> On Feb. 1, 2016, 1:46 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java, line 76
> > <https://reviews.apache.org/r/42850/diff/3/?file=1227613#file1227613line76>
> >
> > Can it be static and shared by all threads?
This will be done.
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/#review117209
-----------------------------------------------------------
On Feb. 1, 2016, 12:28 p.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42850/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 12:28 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-909
> https://issues.apache.org/jira/browse/LENS-909
>
>
> Repository: lens
>
>
> Description
> -------
>
> We should avoid sending email notification with inmemory results
>
> ** Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921) **
> Changes wrt to lens-921 are done in following files only
> - lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
> - lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
>
> Diff: https://reviews.apache.org/r/42850/diff/
>
>
> Testing
> -------
>
> [INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
> [INFO] Lens .............................................. SUCCESS [3.340s]
> [INFO] Lens API .......................................... SUCCESS [20.204s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
> [INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
> [INFO] Lens DB storage ................................... SUCCESS [15.304s]
> [INFO] Lens Query Library ................................ SUCCESS [12.357s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
> [INFO] Lens Server ....................................... SUCCESS [8:58.139s]
> [INFO] Lens client ....................................... SUCCESS [30.351s]
> [INFO] Lens CLI .......................................... SUCCESS [45.652s]
> [INFO] Lens Examples ..................................... SUCCESS [6.089s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
> [INFO] Lens Distribution ................................. SUCCESS [7.953s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
> [INFO] Lens Regression ................................... SUCCESS [10.147s]
> [INFO] Lens UI ........................................... SUCCESS [28.590s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:27.663s
> [INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
> [INFO] Final Memory: 154M/2035M
> [INFO] ------------------------------------------------------------------------
>
>
> **Email Message looks like this**
> (org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
> by localhost
> with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
> Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> From: blah@company.com
> To: foo@localhost
> Cc: foo1@localhost
> Cc: foo2@localhost
> Cc: foo3@localhost
> Message-ID: <12...@IM1995-X0>
> Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
> MIME-Version: 1.0
> Content-Type: multipart/mixed;
> boundary="----=_Part_0_748061076.1453736125428"
>
> ------=_Part_0_748061076.1453736125428
> Content-Type: text/plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
>
> *Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
> ------=_Part_0_748061076.1453736125428--
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 42850: Lens 909 - avoid sending email notification
with inmemory results
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/#review117209
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java (line 76)
<https://reviews.apache.org/r/42850/#comment178333>
Can it be static and shared by all threads?
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java (line 198)
<https://reviews.apache.org/r/42850/#comment178335>
Can we update test to check for time?
- Amareshwari Sriramadasu
On Feb. 1, 2016, 12:28 p.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42850/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 12:28 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-909
> https://issues.apache.org/jira/browse/LENS-909
>
>
> Repository: lens
>
>
> Description
> -------
>
> We should avoid sending email notification with inmemory results
>
> ** Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921) **
> Changes wrt to lens-921 are done in following files only
> - lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
> - lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
>
> Diff: https://reviews.apache.org/r/42850/diff/
>
>
> Testing
> -------
>
> [INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
> [INFO] Lens .............................................. SUCCESS [3.340s]
> [INFO] Lens API .......................................... SUCCESS [20.204s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
> [INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
> [INFO] Lens DB storage ................................... SUCCESS [15.304s]
> [INFO] Lens Query Library ................................ SUCCESS [12.357s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
> [INFO] Lens Server ....................................... SUCCESS [8:58.139s]
> [INFO] Lens client ....................................... SUCCESS [30.351s]
> [INFO] Lens CLI .......................................... SUCCESS [45.652s]
> [INFO] Lens Examples ..................................... SUCCESS [6.089s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
> [INFO] Lens Distribution ................................. SUCCESS [7.953s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
> [INFO] Lens Regression ................................... SUCCESS [10.147s]
> [INFO] Lens UI ........................................... SUCCESS [28.590s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:27.663s
> [INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
> [INFO] Final Memory: 154M/2035M
> [INFO] ------------------------------------------------------------------------
>
>
> **Email Message looks like this**
> (org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
> by localhost
> with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
> Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> From: blah@company.com
> To: foo@localhost
> Cc: foo1@localhost
> Cc: foo2@localhost
> Cc: foo3@localhost
> Message-ID: <12...@IM1995-X0>
> Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
> MIME-Version: 1.0
> Content-Type: multipart/mixed;
> boundary="----=_Part_0_748061076.1453736125428"
>
> ------=_Part_0_748061076.1453736125428
> Content-Type: text/plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
>
> *Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
> ------=_Part_0_748061076.1453736125428--
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 42850: Lens 909 - avoid sending email notification
with inmemory results
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Feb. 1, 2016, 1:28 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java, line 119
> > <https://reviews.apache.org/r/42850/diff/3/?file=1227613#file1227613line119>
> >
> > Lets read from conf passed instead of static conf.
Seems not fixed in the diff. Please check.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/#review117207
-----------------------------------------------------------
On Feb. 5, 2016, 3:09 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42850/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 3:09 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-909
> https://issues.apache.org/jira/browse/LENS-909
>
>
> Repository: lens
>
>
> Description
> -------
>
> We should avoid sending email notification with inmemory results
>
> ** Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921) **
> Changes wrt to lens-921 are done in following files only
> - lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
> - lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java e97a5a3
>
> Diff: https://reviews.apache.org/r/42850/diff/
>
>
> Testing
> -------
>
> [INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
> [INFO] Lens .............................................. SUCCESS [3.340s]
> [INFO] Lens API .......................................... SUCCESS [20.204s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
> [INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
> [INFO] Lens DB storage ................................... SUCCESS [15.304s]
> [INFO] Lens Query Library ................................ SUCCESS [12.357s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
> [INFO] Lens Server ....................................... SUCCESS [8:58.139s]
> [INFO] Lens client ....................................... SUCCESS [30.351s]
> [INFO] Lens CLI .......................................... SUCCESS [45.652s]
> [INFO] Lens Examples ..................................... SUCCESS [6.089s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
> [INFO] Lens Distribution ................................. SUCCESS [7.953s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
> [INFO] Lens Regression ................................... SUCCESS [10.147s]
> [INFO] Lens UI ........................................... SUCCESS [28.590s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:27.663s
> [INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
> [INFO] Final Memory: 154M/2035M
> [INFO] ------------------------------------------------------------------------
>
>
> **Email Message looks like this**
> (org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
> by localhost
> with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
> Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> From: blah@company.com
> To: foo@localhost
> Cc: foo1@localhost
> Cc: foo2@localhost
> Cc: foo3@localhost
> Message-ID: <12...@IM1995-X0>
> Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
> MIME-Version: 1.0
> Content-Type: multipart/mixed;
> boundary="----=_Part_0_748061076.1453736125428"
>
> ------=_Part_0_748061076.1453736125428
> Content-Type: text/plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
>
> *Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
> ------=_Part_0_748061076.1453736125428--
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 42850: Lens 909 - avoid sending email notification
with inmemory results
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/#review117207
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java (line 119)
<https://reviews.apache.org/r/42850/#comment178332>
Lets read from conf passed instead of static conf.
- Amareshwari Sriramadasu
On Feb. 1, 2016, 12:28 p.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42850/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 12:28 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-909
> https://issues.apache.org/jira/browse/LENS-909
>
>
> Repository: lens
>
>
> Description
> -------
>
> We should avoid sending email notification with inmemory results
>
> ** Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921) **
> Changes wrt to lens-921 are done in following files only
> - lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
> - lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
>
> Diff: https://reviews.apache.org/r/42850/diff/
>
>
> Testing
> -------
>
> [INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
> [INFO] Lens .............................................. SUCCESS [3.340s]
> [INFO] Lens API .......................................... SUCCESS [20.204s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
> [INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
> [INFO] Lens DB storage ................................... SUCCESS [15.304s]
> [INFO] Lens Query Library ................................ SUCCESS [12.357s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
> [INFO] Lens Server ....................................... SUCCESS [8:58.139s]
> [INFO] Lens client ....................................... SUCCESS [30.351s]
> [INFO] Lens CLI .......................................... SUCCESS [45.652s]
> [INFO] Lens Examples ..................................... SUCCESS [6.089s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
> [INFO] Lens Distribution ................................. SUCCESS [7.953s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
> [INFO] Lens Regression ................................... SUCCESS [10.147s]
> [INFO] Lens UI ........................................... SUCCESS [28.590s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:27.663s
> [INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
> [INFO] Final Memory: 154M/2035M
> [INFO] ------------------------------------------------------------------------
>
>
> **Email Message looks like this**
> (org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
> by localhost
> with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
> Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
> From: blah@company.com
> To: foo@localhost
> Cc: foo1@localhost
> Cc: foo2@localhost
> Cc: foo3@localhost
> Message-ID: <12...@IM1995-X0>
> Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
> MIME-Version: 1.0
> Content-Type: multipart/mixed;
> boundary="----=_Part_0_748061076.1453736125428"
>
> ------=_Part_0_748061076.1453736125428
> Content-Type: text/plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
>
> *Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
> ------=_Part_0_748061076.1453736125428--
>
>
> Thanks,
>
> Puneet Gupta
>
>
Re: Review Request 42850: Lens 909 - avoid sending email notification
with inmemory results
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/
-----------------------------------------------------------
(Updated Feb. 1, 2016, 12:28 p.m.)
Review request for lens.
Changes
-------
Updated patch after merging with master
Bugs: LENS-909
https://issues.apache.org/jira/browse/LENS-909
Repository: lens
Description
-------
We should avoid sending email notification with inmemory results
** Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921) **
Changes wrt to lens-921 are done in following files only
- lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
- lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2
Diff: https://reviews.apache.org/r/42850/diff/
Testing
-------
[INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
[INFO] Lens .............................................. SUCCESS [3.340s]
[INFO] Lens API .......................................... SUCCESS [20.204s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
[INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
[INFO] Lens DB storage ................................... SUCCESS [15.304s]
[INFO] Lens Query Library ................................ SUCCESS [12.357s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
[INFO] Lens Server ....................................... SUCCESS [8:58.139s]
[INFO] Lens client ....................................... SUCCESS [30.351s]
[INFO] Lens CLI .......................................... SUCCESS [45.652s]
[INFO] Lens Examples ..................................... SUCCESS [6.089s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
[INFO] Lens Distribution ................................. SUCCESS [7.953s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
[INFO] Lens Regression ................................... SUCCESS [10.147s]
[INFO] Lens UI ........................................... SUCCESS [28.590s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:27.663s
[INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
[INFO] Final Memory: 154M/2035M
[INFO] ------------------------------------------------------------------------
**Email Message looks like this**
(org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
by localhost
with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
Mon, 25 Jan 2016 21:05:25 +0530 (IST)
Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
From: blah@company.com
To: foo@localhost
Cc: foo1@localhost
Cc: foo2@localhost
Cc: foo3@localhost
Message-ID: <12...@IM1995-X0>
Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="----=_Part_0_748061076.1453736125428"
------=_Part_0_748061076.1453736125428
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
*Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
------=_Part_0_748061076.1453736125428--
Thanks,
Puneet Gupta
Re: Review Request 42850: Lens 909 - avoid sending email notification
with inmemory results
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/
-----------------------------------------------------------
(Updated Feb. 1, 2016, 5:36 a.m.)
Review request for lens.
Summary (updated)
-----------------
Lens 909 - avoid sending email notification with inmemory results
Bugs: LENS-909
https://issues.apache.org/jira/browse/LENS-909
Repository: lens
Description (updated)
-------
We should avoid sending email notification with inmemory results
** Note :This is an incremental patch on top of lens-921 (as it needs few configrations added in lens-921) **
Changes wrt to lens-921 are done in following files only
- lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java
- lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc07d34fed709deb964268a8b3150dc96306
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd8162515fe8508718502b789af328e6d3a
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d6185e8bebbc631b7b381591acd22d04a4
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 672f2bea36af4040e17d4d70b14ea0e1c773d5d9
lens-server/src/main/resources/lensserver-default.xml cac641abca105827eaa058f35faae40d961bc1c1
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2770cddf3c7b13a40238db0380361ab8b4
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 3facded051fdd89bc9838ef2b60a91138fd40424
lens-server/src/test/resources/lens-site.xml 9cb4a6f6dcdce5522f9a37a2cb76e98699eecc56
src/site/apt/admin/config.apt 54f827e8b18b139a6ade8b480881bdf9a7942306
src/site/apt/admin/session-config.apt 05a2c2c711e8c4b85ae7e43d71ffc1d883ca2ebe
Diff: https://reviews.apache.org/r/42850/diff/
Testing
-------
[INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
[INFO] Lens .............................................. SUCCESS [3.340s]
[INFO] Lens API .......................................... SUCCESS [20.204s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
[INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
[INFO] Lens DB storage ................................... SUCCESS [15.304s]
[INFO] Lens Query Library ................................ SUCCESS [12.357s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
[INFO] Lens Server ....................................... SUCCESS [8:58.139s]
[INFO] Lens client ....................................... SUCCESS [30.351s]
[INFO] Lens CLI .......................................... SUCCESS [45.652s]
[INFO] Lens Examples ..................................... SUCCESS [6.089s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
[INFO] Lens Distribution ................................. SUCCESS [7.953s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
[INFO] Lens Regression ................................... SUCCESS [10.147s]
[INFO] Lens UI ........................................... SUCCESS [28.590s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:27.663s
[INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
[INFO] Final Memory: 154M/2035M
[INFO] ------------------------------------------------------------------------
**Email Message looks like this**
(org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
by localhost
with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
Mon, 25 Jan 2016 21:05:25 +0530 (IST)
Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
From: blah@company.com
To: foo@localhost
Cc: foo1@localhost
Cc: foo2@localhost
Cc: foo3@localhost
Message-ID: <12...@IM1995-X0>
Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="----=_Part_0_748061076.1453736125428"
------=_Part_0_748061076.1453736125428
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
*Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
------=_Part_0_748061076.1453736125428--
Thanks,
Puneet Gupta
Re: Review Request 42850: bug fix
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42850/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 11:31 a.m.)
Review request for lens.
Changes
-------
moved creation of inMemoryResultsetTTLSecs to constructor
Summary (updated)
-----------------
bug fix
Bugs: LENS-909
https://issues.apache.org/jira/browse/LENS-909
Repository: lens
Description (updated)
-------
updated
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java a3dbfc07d34fed709deb964268a8b3150dc96306
lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java c64a3dd8162515fe8508718502b789af328e6d3a
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java ca00b4d6185e8bebbc631b7b381591acd22d04a4
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 672f2bea36af4040e17d4d70b14ea0e1c773d5d9
lens-server/src/main/resources/lensserver-default.xml cac641abca105827eaa058f35faae40d961bc1c1
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 4ac42b2770cddf3c7b13a40238db0380361ab8b4
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 3facded051fdd89bc9838ef2b60a91138fd40424
lens-server/src/test/resources/lens-site.xml 9cb4a6f6dcdce5522f9a37a2cb76e98699eecc56
src/site/apt/admin/config.apt 54f827e8b18b139a6ade8b480881bdf9a7942306
src/site/apt/admin/session-config.apt 05a2c2c711e8c4b85ae7e43d71ffc1d883ca2ebe
Diff: https://reviews.apache.org/r/42850/diff/
Testing
-------
[INFO] Installing /d0/jenkins/workspace/Platform_Common_Job/lens-ui/pom.xml to /home/jenkins/.m2/repository/org/apache/lens/lens-ui/2.5.0-beta-SNAPSHOT/lens-ui-2.5.0-beta-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.306s]
[INFO] Lens .............................................. SUCCESS [3.340s]
[INFO] Lens API .......................................... SUCCESS [20.204s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.930s]
[INFO] Lens Cube ......................................... SUCCESS [11:47.315s]
[INFO] Lens DB storage ................................... SUCCESS [15.304s]
[INFO] Lens Query Library ................................ SUCCESS [12.357s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:24.715s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [31.336s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [14.232s]
[INFO] Lens Server ....................................... SUCCESS [8:58.139s]
[INFO] Lens client ....................................... SUCCESS [30.351s]
[INFO] Lens CLI .......................................... SUCCESS [45.652s]
[INFO] Lens Examples ..................................... SUCCESS [6.089s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.711s]
[INFO] Lens Distribution ................................. SUCCESS [7.953s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:08.974s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.287s]
[INFO] Lens Regression ................................... SUCCESS [10.147s]
[INFO] Lens UI ........................................... SUCCESS [28.590s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:27.663s
[INFO] Finished at: Wed Jan 27 10:34:30 UTC 2016
[INFO] Final Memory: 154M/2035M
[INFO] ------------------------------------------------------------------------
**Email Message looks like this**
(org.subethamail.wiser.WiserMessage) Received: from IM1995-X0 (localhost [127.0.0.1])
by localhost
with SMTP (SubEthaSMTP 3.1.7) id IJU4YDE8;
Mon, 25 Jan 2016 21:05:25 +0530 (IST)
Date: Mon, 25 Jan 2016 21:05:25 +0530 (IST)
From: blah@company.com
To: foo@localhost
Cc: foo1@localhost
Cc: foo2@localhost
Cc: foo3@localhost
Message-ID: <12...@IM1995-X0>
Subject: Query SUCCESSFUL: 3f23cd96-45b3-4aeb-a55a-8b3c5d222f02
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="----=_Part_0_748061076.1453736125428"
------=_Part_0_748061076.1453736125428
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
*Query Result is availabe in server and can be accessed until 2016-01-25 07:05:46 PM, IST*
------=_Part_0_748061076.1453736125428--
Thanks,
Puneet Gupta