You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by dossett <gi...@git.apache.org> on 2015/06/07 22:15:55 UTC

[GitHub] storm pull request: In TestHiveBolt make the collector mock slight...

GitHub user dossett opened a pull request:

    https://github.com/apache/storm/pull/583

    In TestHiveBolt make the collector mock slightly more precise

    The OutputCollector passed to bolt.prepare() can be mocked directly instead of mocking an IOutputCollector used to construct the collector each time.  This makes the tests slightly more readable and it will be easier to verify more complex interactions with the collector in the future if needed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dossett/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/583.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #583
    
----
commit fa84ae32e29c939388ebd08e39b7de8e42483b18
Author: Aaron Dossett <aa...@target.com>
Date:   2015-06-07T20:10:57Z

    make the collector mock slightly more precise

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-943: In TestHiveBolt make the collector ...

Posted by dossett <gi...@git.apache.org>.
Github user dossett closed the pull request at:

    https://github.com/apache/storm/pull/583


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-943: In TestHiveBolt make the collector ...

Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on the pull request:

    https://github.com/apache/storm/pull/583#issuecomment-146966594
  
    @HeartSaVioR Will do, apologies for the oversight!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: In TestHiveBolt make the collector mock slight...

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/583#issuecomment-122082381
  
    +1
    @dossett do you want to file a JIRA for this?  It is not a big deal because it is such a small change, but it does impact what type of credit you get for your changes.  No JIRA currently means it does not show up in the change log.  Which usually is not a big deal for doc changes, but is slightly more important for code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-943: In TestHiveBolt make the collector ...

Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on the pull request:

    https://github.com/apache/storm/pull/583#issuecomment-138607384
  
    @revans2 Per your suggestion I did create a JIRA and associate it.  Feel free to merge this at your convenience.  Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-943: In TestHiveBolt make the collector ...

Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on the pull request:

    https://github.com/apache/storm/pull/583#issuecomment-122118472
  
    Thanks for the feedback @revans2.  STORM-943 created and associated to this JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: In TestHiveBolt make the collector mock slight...

Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:

    https://github.com/apache/storm/pull/583#issuecomment-113996410
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-943: In TestHiveBolt make the collector ...

Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on the pull request:

    https://github.com/apache/storm/pull/583#issuecomment-146965188
  
    @HeartSaVioR Could you merge this?  Thank you! :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-943: In TestHiveBolt make the collector ...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/583#issuecomment-146966015
  
    @dossett 
    As you can see, there's no diff. Seems like it is already applied to master in any way.
    Could you close this PR? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-943: In TestHiveBolt make the collector ...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/583#issuecomment-146966599
  
    Seems like STORM-938 contains this patch.
    I'd like to recommend you to use branch so each pull request doesn't affect other pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---