[jira] [Commented] (MESOS-5343) Behavior of custom HTTP authenticators with disabled HTTP authentication is inconsistent between master and agent

["Adam B (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277678#comment-15277678 ] 

Adam B commented on MESOS-5343:
-------------------------------

Quite an annoying inconsistency. I would think that we should allow users to load a custom http_authenticator without requiring them to enable authentication. We could WARN in that case rather than EXIT.
However, agent http authentication was added later, so I would think that the deviation was intentional, with an intent to change master to match. I'd be fine with either, but we should try to be consistent.

> Behavior of custom HTTP authenticators with disabled HTTP authentication is inconsistent between master and agent
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: MESOS-5343
>                 URL: https://issues.apache.org/jira/browse/MESOS-5343
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Benjamin Bannier
>             Fix For: 0.29.0
>
>
> When setting a custom authenticator with {{http_authenticators}} and also specifying {{authenticate_http=false}} currently agents refuse to start with
> {code}
> A custom HTTP authenticator was specified with the '--http_authenticators' flag, but HTTP authentication was not enabled via '--authenticate_http'
> {code}
> Masters on the other hand accept this setting.
> Having differing behavior between master and agents is confusing, and we should decide on whether we want to accept these settings or not, and make the implementations consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)