You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by GitBox <gi...@apache.org> on 2019/09/25 00:21:26 UTC
[GitHub] [any23] HansBrende commented on a change in pull request #143:
ANY23-183 Address javac warning's in Any23 code base
HansBrende commented on a change in pull request #143: ANY23-183 Address javac warning's in Any23 code base
URL: https://github.com/apache/any23/pull/143#discussion_r327886999
##########
File path: pom.xml
##########
@@ -263,8 +263,8 @@
<project.build.resourceEncoding>UTF-8</project.build.resourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
- <javac.src.version>1.8</javac.src.version>
- <javac.target.version>1.8</javac.target.version>
+ <javac.src.version>13</javac.src.version>
+ <javac.target.version>13</javac.target.version>
Review comment:
Can we keep this at 1.8? I don't think we should increase the java version until we are forced to do so by one of our dependencies. There are a *lot* of applications still on java 8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services