You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/20 17:59:59 UTC
[GitHub] [superset] kgabryje opened a new pull request, #19794: Feat/rearrange controls 1
kgabryje opened a new pull request, #19794:
URL: https://github.com/apache/superset/pull/19794
### SUMMARY
Rearrange controls in some of the most popular charts:
- Table
- Bar
- Echarts Timeseries
- Big number
- World map
- Pivot table
This is the first stage of changing order and names of controls in charts. Updates for the rest of the charts coming in the next couple of weeks!
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/15073128/164293537-9954f6c0-b492-4579-b84d-704fa0b797c3.mov
### TESTING INSTRUCTIONS
Make sure that the charts listed in summary work like before
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
CC @kasiazjc @lauderbaugh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #19794: feat(explore): Rearrange controls in most popular charts
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1105021750
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19794: feat(explore): Rearrange controls in most popular charts
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1105116687
@kgabryje Ephemeral environment spinning up at http://34.221.36.25:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on pull request #19794: feat(explore): Rearrange controls in most popular charts
Posted by GitBox <gi...@apache.org>.
kasiazjc commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1105164946
Checked in testing env and it looks great! Thanks π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #19794: feat(explore): Rearrange controls in most popular charts
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1271932968
@kgabryje Should we rebase this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #19794: feat(explore): Rearrange controls in most popular charts
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1104988681
@lauderbaugh As Ville pointed out, this change needs a product sign off. Can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19794: feat(explore): Rearrange controls in most popular charts
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1382126022
Any idea how long this will be on hold? Wondering if it should just be converted to draft for safety, or even closed and re-opened if the day ever comes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #19794: feat(explore): Rearrange controls in most popular charts
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1104978304
1. After a discussion with @villebro we decided to stick with "Chart" for now
2. As for Mixed Timeseries, that chart has a more complex control panel since we configure 2 queries - Query A and Query B. If we were to use the same pattern as in other charts in this PR, we'd have a structure `Query A, Filter A, Advanced query settings A, Query b, Filter B, Advanced query settings B` and that's not what we aim for. For that reason I'm going to leave it as it is for now and wait for design input. @kasiazjc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on pull request #19794: feat(explore): Rearrange controls in most popular charts
Posted by GitBox <gi...@apache.org>.
kasiazjc commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1104849409
> A few thoughts:
>
> - I've probably raised this many times before, but I'll do it once more, just in case π The title "Chart" (instead of "Query") could be seen as slightly ambiguous, as everything should affect the chart. While I know that "Query" isn't very business user friendly, maybe there's some other term out there that could convey more clearly what these controls are.
>
> - I noticed that Mixed Timeseries isn't included in this PR. Could we update that one, too?
I think we were on the fence on how to name this section... Like "Required"/"Basic", but I don't think it makes sense π« I think for now we can change the name to "query" and adjust later. This section will always be opened as there are all (I think in most cases) required controls, so shouldn't be a problem.
We included only Tier 1 charts, but I guess as Mixed Timerseries is similar we can tackle that one too, @kgabryje?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(explore): Rearrange controls in most popular charts [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #19794: feat(explore): Rearrange controls in most popular charts
URL: https://github.com/apache/superset/pull/19794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #19794: feat(explore): Rearrange controls in most popular charts
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1105114360
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19794: feat(explore): Rearrange controls in most popular charts
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1104387975
# [Codecov](https://codecov.io/gh/apache/superset/pull/19794?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19794](https://codecov.io/gh/apache/superset/pull/19794?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d73602) into [master](https://codecov.io/gh/apache/superset/commit/5e468f7a4cccc496ccafa52f9aba5b7688145fe4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e468f7) will **not change** coverage.
> The diff coverage is `16.66%`.
```diff
@@ Coverage Diff @@
## master #19794 +/- ##
=======================================
Coverage 66.54% 66.54%
=======================================
Files 1692 1692
Lines 64775 64775
Branches 6661 6661
=======================================
Hits 43103 43103
Misses 19972 19972
Partials 1700 1700
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.24% <16.66%> (ΓΈ)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...omponents/ColumnConfigControl/ColumnConfigItem.tsx](https://codecov.io/gh/apache/superset/pull/19794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9jb21wb25lbnRzL0NvbHVtbkNvbmZpZ0NvbnRyb2wvQ29sdW1uQ29uZmlnSXRlbS50c3g=) | `0.00% <ΓΈ> (ΓΈ)` | |
| [.../legacy-plugin-chart-world-map/src/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/19794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXdvcmxkLW1hcC9zcmMvY29udHJvbFBhbmVsLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...gacy-preset-chart-nvd3/src/DistBar/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/19794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL0Rpc3RCYXIvY29udHJvbFBhbmVsLnRz) | `11.11% <ΓΈ> (ΓΈ)` | |
| [.../BigNumber/BigNumberWithTrendline/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/19794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlcldpdGhUcmVuZGxpbmUvY29udHJvbFBhbmVsLnRzeA==) | `33.33% <ΓΈ> (ΓΈ)` | |
| [...chart-echarts/src/Timeseries/Area/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/19794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9BcmVhL2NvbnRyb2xQYW5lbC50c3g=) | `40.00% <ΓΈ> (ΓΈ)` | |
| [...charts/src/Timeseries/Regular/Bar/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/19794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL0Jhci9jb250cm9sUGFuZWwudHN4) | `40.00% <ΓΈ> (ΓΈ)` | |
| [...ts/src/Timeseries/Regular/Scatter/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/19794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL1NjYXR0ZXIvY29udHJvbFBhbmVsLnRzeA==) | `40.00% <ΓΈ> (ΓΈ)` | |
| [...rt-echarts/src/Timeseries/Regular/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/19794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL2NvbnRyb2xQYW5lbC50c3g=) | `40.00% <ΓΈ> (ΓΈ)` | |
| [...chart-echarts/src/Timeseries/Step/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/19794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9TdGVwL2NvbnRyb2xQYW5lbC50c3g=) | `33.33% <ΓΈ> (ΓΈ)` | |
| [...ugin-chart-pivot-table/src/plugin/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/19794/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGl2b3QtdGFibGUvc3JjL3BsdWdpbi9jb250cm9sUGFuZWwudHN4) | `12.50% <ΓΈ> (ΓΈ)` | |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/19794/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19794?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19794?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5e468f7...7d73602](https://codecov.io/gh/apache/superset/pull/19794?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #19794: feat(explore): Rearrange controls in most popular charts
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1104797069
A few thoughts:
- I've probably raised this many times before, but I'll do it once more, just in case π The title "Chart" (instead of "Query") could be seen as slightly ambiguous, as everything should affect the chart. While I know that "Query" isn't very business user friendly, maybe there's some other term out there that could convey more clearly what these controls are.
- I noticed that Mixed Timeseries isn't included in this PR. Could we update that one, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #19794: feat(explore): Rearrange controls in most popular charts
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1271934096
> @kgabryje Can you rebase the PR and possibly remove the `hold` label?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lauderbaugh commented on pull request #19794: feat(explore): Rearrange controls in most popular charts
Posted by GitBox <gi...@apache.org>.
lauderbaugh commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1105257978
Looks good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #19794: feat(explore): Rearrange controls in most popular charts
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1384235917
@rusackas Unfortunately this has been pushed far down the list of priorities :( I'm going to convert it to draft and hopefully we can get back to it in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(explore): Rearrange controls in most popular charts [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1927993474
Re-open if/when the day comes. I still love the effort here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org