You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by senthilec566 <gi...@git.apache.org> on 2016/03/03 11:06:54 UTC
[GitHub] incubator-eagle pull request: Added RM Policy and GC Policies in R...
GitHub user senthilec566 opened a pull request:
https://github.com/apache/incubator-eagle/pull/109
Added RM Policy and GC Policies in Resource
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/senthilec566/incubator-eagle EAGLE-180
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #109
----
commit d78c4bcf85f7d3d7b5c3c219ea03825aa48826d4
Author: senthilkumar <se...@ebay.com>
Date: 2016-03-03T09:13:54Z
added RM policy and gc policies
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: Added RM Policy and GC Policies in R...
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/109#issuecomment-192211050
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: Added RM Policy and GC Policies in R...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: Added RM Policy and GC Policies in R...
Posted by senthilec566 <gi...@git.apache.org>.
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/109#issuecomment-192224455
Looks like One TestCase Failed
Results :
Failed tests:
TestStrEqualsIgnoreCase(org.apache.eagle.alert.siddhi.TestSiddhiEngine)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: Added RM Policy and GC Policies in R...
Posted by senthilec566 <gi...@git.apache.org>.
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/109#issuecomment-192186776
@RalphSu @qingwen220 , Can we merge this into master if its not require any more change in script ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: Added RM Policy and GC Policies in R...
Posted by senthilec566 <gi...@git.apache.org>.
Github user senthilec566 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/109#issuecomment-192117041
@qingwen220 Repaced dataSource with application field.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: Added RM Policy and GC Policies in R...
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/109#issuecomment-193085957
Hi @senthilec566
Michael have checked with it, and this problem may be caused by Jenkins's instability. You can do a little bit of modifications to this pr, and confirm it again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: Added RM Policy and GC Policies in R...
Posted by RalphSu <gi...@git.apache.org>.
Github user RalphSu commented on the pull request:
https://github.com/apache/incubator-eagle/pull/109#issuecomment-192119175
Looks good to me.
+1
@qingwen220 please help review as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: Added RM Policy and GC Policies in R...
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/109#issuecomment-193063332
I found it and run it in my local environment, and it's OK! Could you check it as well? If this is caused by jenkins, we will report this bug to Michael. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: Added RM Policy and GC Policies in R...
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the pull request:
https://github.com/apache/incubator-eagle/pull/109#issuecomment-192207524
@senthilec566 I saw the jenkins build failed. Could you please check the details and make sure the merge won't break down the code compilation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---