You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by oknet <gi...@git.apache.org> on 2016/09/01 12:13:52 UTC
[GitHub] trafficserver pull request #952: TS-4804: Add r into total_written only if r...
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/952
TS-4804: Add r into total_written only if r > 0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oknet/trafficserver TS-4804
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/952.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #952
----
commit bf7229004151d48a8313f962f94f3c7b659aae2e
Author: Oknet Xu <xu...@skyguard.com.cn>
Date: 2016-09-01T12:12:05Z
TS-4804: Add r into total_written only if r > 0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #952: TS-4804: Add r into total_written only if r > 0
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/952
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/560/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #952: TS-4804: Add r into total_written only if r > 0
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/952
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #952: TS-4804: Add r into total_written only if r > 0
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/952
Also, is a value of r < 0 an expected behavior, or is that some sort of error case that is not handled properly ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #952: TS-4804: Add r into total_written only if r > 0
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/952
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/665/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #952: TS-4804: Add r into total_written only if r...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/952
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #952: TS-4804: Add r into total_written only if r > 0
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/952
@zwoop negative means error. man 2 writev:
RETURN VALUES
Upon successful completion the number of bytes which were written is returned. Otherwise, a -1 is returned and the global variable errno is set to indicate the error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #952: TS-4804: Add r into total_written only if r > 0
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/952
Interesting. How does this manifest itself? Is it possible that r is < 0, and we go negative?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---